-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add material design loading icon #2727
Conversation
96bd0b3
to
7f916d6
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
7f916d6
to
2b04c17
Compare
Please also add a way to override the colour :) |
Maybe either pass all props or declare all props from vue-mdi ( |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: greta <gretadoci@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any strong opinions on changing the colour of the spinner, but the default colour of the spinner should the same as the text in the button. If that's how it is right now, then 🚀🚀🚀
ee40770
to
c3e1207
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
c3e1207
to
ba3cc97
Compare
Not sure, what you mean. There is no button in the component 🤔 The default color used now is The spinning part of the old |
Let's keep using that one please yes. |
But developers should not be able to pick any color for the spinner – it should just be light or dark, depending on the background? |
Fair enough, a color prop might be too strong, maybe a force-dark or force-white prop that limit the colours being used? |
@skjnldsv that would not work with light and dark theme though, right? We need
This could possibly be automated depending on the parent, e.g. it would be 1) most often, but if it’s in a primary button it would automatically be 2). |
How about a prop Edit: @jancborchardt Sorry, didn't see your comment before submitting mine. |
Yes, perfect! @jancborchardt for 4, this what we're discussing.
We do not use the loading primary anywhere at nextcloud. Please provide clear guidelines on why and when to use them in an issue so we can implement this if it's really necessary 🙏 |
This adds a component to show a loading icon with a material design icon.