Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessible EmptyContent component #2867

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Accessible EmptyContent component #2867

merged 1 commit into from
Jul 26, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jul 21, 2022

@Pytal Pytal added 2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: emptycontent Related to the emptycontent component labels Jul 21, 2022
@Pytal Pytal added this to the 6.0.0 milestone Jul 21, 2022
@Pytal Pytal self-assigned this Jul 21, 2022
@Pytal
Copy link
Contributor Author

Pytal commented Jul 23, 2022

Would it make sense to recommend adding the accessible title prop to EmptyContent icons @nimishavijay?

It would show a tooltip like below whenever you hover over the icon

image

@Pytal Pytal force-pushed the enh/a11y-empty-content branch 2 times, most recently from 63d65e0 to 26884e0 Compare July 23, 2022 00:25
@nimishavijay
Copy link

Would it make sense to recommend adding the accessible title prop to EmptyContent icons?
It would show a tooltip like below whenever you hover over the icon

I would say this image is decorative, as all the information required by a person on this page is given through the text.

If the purpose of a title prop here is to make the page screen-reader friendly, I would day we don't need to include it here because there should be a some supporting text under the icon, and that works for a screenreader also :)

cc @jancborchardt

@jancborchardt
Copy link
Contributor

Yep, as so often the icon is decorative and has its text there as h2, and thus should have empty alt text alt="" to designate that it's decorative and no title to prevent duplication.

- Drop support for class based icons
- Title is now optional

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 26, 2022
@Pytal Pytal marked this pull request as ready for review July 26, 2022 00:30
@nickvergessen nickvergessen added the breaking PR that requires a new major version label Jul 26, 2022
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2022
@Pytal Pytal merged commit 6b6b3a4 into master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities breaking PR that requires a new major version feature: emptycontent Related to the emptycontent component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV/A11Y] EmptyContent accessibility
6 participants