Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focusing last action with page-down #2961

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

raimund-schluessler
Copy link
Contributor

This PR fixes focusing the last action with page-down, which is currently broken. Closes #2958.

I also cleaned up two unused icon classes that I missed to remove in #2927.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 5.4.1 milestone Aug 6, 2022
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Aug 6, 2022
Copy link
Contributor

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but assume you did. 😉

@raimund-schluessler
Copy link
Contributor Author

/backport to stable5

Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works :)

@marcoambrosini marcoambrosini merged commit fd7a07e into master Aug 8, 2022
@marcoambrosini marcoambrosini deleted the fix/2958/focus-last-action branch August 8, 2022 09:24
@backportbot-nextcloud
Copy link

The backport to stable5 failed. Please do this backport manually.

@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focusing last action in Actions component with page-down is broken
3 participants