Fix outdated variables #3367
Merged
Fix outdated variables #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
jancborchardt
added
bug
jancborchardt
requested review from
raimund-schluessler,
skjnldsv,
CarlSchwan and
marcoambrosini
skjnldsv
approved these changes
Nov 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated --color-text-lighter with --color-text-maxcontrast & Replace deprecated --color-text-light with --color-main-text
We should never ever use
--color-text-lighter(or "light") anymore.color-text-light→color-main-textcolor-text-lighter→color-text-maxcontrastCould we fully deprecate the old variables?
Progressive enhancement for outdated --color-primary-element-lighter
The --lighter does not exist in new versions anymore, so currently a button with
type=""(empty, as opposed to no type property ortype="secondary"actually does not show any background. This fixes that.