fix(NcAppNavigationItem): Make sure that icon-collapse styles take precendense over NcButton styles #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecendense over NcButton styles Signed-off-by: Julius Härtl <jus@bitgrid.net>
raimund-schluessler
approved these changes
Jan 3, 2023
skjnldsv
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream fix for nextcloud/mail#7856
Fixes nextcloud/deck#4352
Fixes nextcloud/mail#7095
This makes sure that the NcAppNavigationIconCollapsible styles always take precendence over the NcButton ones as for the mail/deck app the loading order seems to be different compared to the vue component docs. Before this the NcButton relative positioning was applied within the apps instead of the absolute one.
Tested and works with deck.