Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datetimepicker full width in NcActionInput #3796

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Make datetimepicker full width in NcActionInput #3796

merged 1 commit into from
Feb 20, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Feb 20, 2023 •
edited
Loading

This PR makes the datetimepickers in NcActionInput the full width.

Before After
Screenshot 2023-02-20 at 13-32-36 Nextcloud Vue Style Guide Screenshot 2023-02-20 at 13-36-17 Nextcloud Vue Style Guide

@raimund-schluessler
Make datetimepicker full width in NcActionInput
597883a 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component feature: actions Related to the actions components design Design, UX, interface and interaction design labels Feb 20, 2023
@raimund-schluessler raimund-schluessler added this to the 7.7.0 milestone Feb 20, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 20, 2023 12:37
ChristophWurst
ChristophWurst approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@nickvergessen nickvergessen merged commit 749109d into master Feb 20, 2023
@nickvergessen nickvergessen deleted the fix/noid/action-input-picker-width branch February 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@susnux susnux Awaiting requested review from susnux

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@mejo- mejo- Awaiting requested review from mejo-

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: actions Related to the actions components feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raimund-schluessler @nickvergessen @ChristophWurst