Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigation): fix flex element styles causing resizing sidebar #4035

Merged
merged 1 commit into from
May 4, 2023
Merged

fix(NcAppNavigation): fix flex element styles causing resizing sidebar #4035

merged 1 commit into from
May 4, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 4, 2023

@ShGKme
fix(NcAppNavigation): fix flex element styles causing resizing sidebar
159d07e 
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme ShGKme added the 3. to review Waiting for reviews label May 4, 2023
@ShGKme ShGKme marked this pull request as ready for review May 4, 2023 13:44
@nickvergessen nickvergessen added this to the 7.11.2 milestone May 4, 2023
@ShGKme ShGKme enabled auto-merge May 4, 2023 13:56
@ShGKme ShGKme added the feature: app-navigation Related to the app-navigation component label May 4, 2023
JuliaKirschenheuter
JuliaKirschenheuter approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking over!

@ShGKme ShGKme disabled auto-merge May 4, 2023 14:07
@ShGKme ShGKme enabled auto-merge May 4, 2023 14:21
@ShGKme ShGKme mentioned this pull request May 4, 2023
Merged
@ShGKme ShGKme merged commit cc3af74 into master May 4, 2023
@ShGKme ShGKme deleted the fix/4016-regression branch May 4, 2023 17:34
@ShGKme ShGKme added bug Something isn't working 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
@ShGKme ShGKme removed the 4. to release Ready to be released and/or waiting for tests to finish label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Antreesy Antreesy Antreesy approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@artonge artonge Awaiting requested review from artonge

Assignees

@ShGKme ShGKme

Labels
bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
7.11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @nickvergessen @JuliaKirschenheuter @Antreesy