-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NCP 1.39.0/NC 21.0.4 fail #1326
Comments
many thanks for testing. Can you share the output of |
also, is this your main instance, or is this a test instance you have around? |
I made a special branch to debug your issue. That url https://10.8.6.100/index.php/apps/notify_push/test/cookie seems plain wrong. Do you mind doing We should get more info from the output this time around |
This is a test instance (RPI 4 4GB) with the NextCloudPi_RPi_11-27-20 image fully updated. I'll do all the tests and place the output here |
Like wise here on a VM (Proxmox), got rollback: |
Host: M1 Mac Mini
NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
2nd try.
NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
Would it work if just build a new image with NC21? Just be so excited with NC21. |
ncp-report after the failed upgrade (ncp-update devel) NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
Test with the instance ncp-update nc-21-vcbranco in the same image but clean (the card was cloned) Update successful
+---------+-------+--------------+ ncp-report NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
The second error ncp-report is at the end. |
part 3. Telegram pinned update instruction result:
'ncp-report' logs: NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
thanks all. Please bear with me, as upgrading to this new HPB is really proving to be a pain given all the moving pieces. Also I don't think it's super well polished. I'll go with your issues one by one. A couple questions: Do you have I wasn't able to reproduce your issue, but I think we are dealing with this rustls/hyper-rustls#84 In any case, please run again
Yes, you can checkout I'll try to replicate your upgrade path next |
Yes, nc-static-ip is activated. I going to start testing and post the results. |
No luck I'm going to setup a test DNS to the upgrade |
Same problem. Let's encrypt and nc-static-IP configured. Starting code integrity check...
+---------+-------+--------------+ ncp-report NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
@nachoparker Thanks for the feedback. I've build an image from the devel branch. My personal NCP is running with the older image with an external hard drive. Can I simply stop the old image, and launch the new image and mount the external drive? Or further setup is required to switch from one image to another with data all in an external drive? Thanks. |
@WeiChihChern that's not how it works, if you want to retain your users, data and so on you need to upgrade, no way around that.
How did you do this? through NC updater or through NCP tools? it seems like you were in a half updated state. I updated from 18 to 20 and then did @vcbranco thanks for your testing. You never shared the output from your second attempt with static IP so I don't know how it went. You just said it didn't work. Then you changed your setup and you shared the output, so we are mixing things here and I cannot trace whether my fix worked or needs adjustments.
what does this mean? on your last output I see https://pi.emcontacto.eu in overwrite.cli.url, but I don't know where it comes from. notify_push seems to have a problem with it. Are you behind a proxy? have you messed with the 'forwarded_for_headers' option in your config.php by any chance? |
@nachoparker I updated apps and nextcloud using ncp-config. I would try it again using your instructions, see how it goes. |
@ovpc if your proxmox VM is disposable (only if), can you also
You error is super weird and super unhelpful and I can't find what library it comes from :/ Thanks |
@WeiChihChern not encouraged to |
@nachoparker
NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
Sorry that I might not use the right words. I understand that the database would retain. In my case, in the external storage that What I am not sure what to do is that, as mentioned if something like power shortage resulting in relaunching a container is required, what is the correct ways to migrate my database, user, etc into a newly launch container? It could be:
|
@WeiChihChern it seems like your backup step is failing? can you just run a backup from
this is what you are not understanding I think, the image does not contain NC18. NC18 lives in a volume, along with the data and the database (and the apps). You can restart the container all you want, or you can even change container versions, as long as you include the same volume you will be in the same "NC instance" (but maybe with a different version of NCP tools). That's how we make sure we are always in sync. |
@nachoparker
Ahh, now I understand it. Thanks for the explanation. |
@nachoparker sorry this VM is not disposible. I will create a fresh one to test this, later on today. |
@nachoparker Security & setup warnings This instance is missing some recommended PHP modules. For improved performance and better compatibility it is highly recommended to install them.
|
@ovpc can you just try again on your original VM? maybe it was a one time glitch 🤔 @WeiChihChern can you add |
@nachoparker
NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
thanks @WeiChihChern let's just run these commands
thanks |
Can you run this command for me please
I want to see if I can automate this, or maybe the |
Here's what I've come to understand about this issue. 1 - The router's IP is added to the trusted proxy Adding the domain to the trusted proxy does not solve the issue curl -v https://pi2.emcontacto.eu/push/test/cookie
|
ummm... Nacho wrote "https://pi.emcontacto.eu/push/test/cookie" with you trying to connect to "https://pi2.emcontacto.eu/push/test/cookie" could that be the problem in your last posting? |
Letsencrypt only issues 5 certificates per week for each address. |
In my case: Upgrade rolled back, notify_push self test failed with http 503, |
@PascalHeynmoeller did you run I think you are on
exactly correct |
Tested the devel repository and everything was OK. |
I tried to test ncp-update nc-21-vcbranco but the installation was downgraded to 1.38.6 |
@nachoparker I I've now made a test run with
but App uses armv7 as directory
After changing the wrong path to the bin in /etc/systemd/system/notify_push.service
So I'm now on NC 21.0.4 with running notify_push. Also asked the notify people to change dir name, as you can see below. NCPi System Info still reports:
|
@PascalHeynmoeller good catch and amazing feedback. I pushed a fix for the armv7 path |
removed |
@ovpc I was able to reproduce the "http2 error: protocol error" on the VM. Zero info on the internet on how to solve this, so I was able to work around it with an ugly sleep. I think we are good to go! |
v1.39.1 Thanks @nachoparker and everyone helping out . |
NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
@vcbranco can you run |
🗴 no push server configured |
what happens if you set it up
|
Sorry, the instance was not activated. |
HPB service down notify_push 0.2.3 installed pi@nextcloudpi:~ $ sudo ncc config:system:set trusted_proxies 15 --value=10.8.6.1 ncp-report NextCloudPi diagnostics
Nextcloud configuration
HTTPd logs
Database logs
Nextcloud logs
|
Now is UP ncc notify_push:self-test ✓ redis is configured |
ah right, the static IP thing. I have to tweak that again
after the commands I pasted? after a reboot? what made it work? |
actually I see no way of making it work with an IP, since you don't have a domain set up yet and HPB just doesn't support that. It should get activated though when letsencrypt or dnsmasq are enabled |
The HPB service started after a reboot In my case my production box as a domain configured, is not a problem. |
Tested ok. The HPB service is up. ncp-update devel If I do not set the proxy before the update I will need to set after the nc-update-nextcloud. It would be better if someone could test with a different router |
great testing, thank you so much |
Maybe just another quirck again, all testing servers upgraded fine, but my production server did not: It gives me an: Error code: SSL_ERROR_RX_RECORD_TOO_LONG sudo ncp-config Please ignore, was instance on (very) old hardware, so moved/restored to a VM on Proxmox now ;-) |
I've seen that SSL error before, I think it's trying to use https on a non https port. HPB is the same thing as notify_push. It's the new high performance backend written in rust to offload user notifications to improve performance. |
So maybe my issue related to https://help.nextcloud.com/t/solved-letsencrypt-renewal-error/123525/8 |
The upgrade does not done.
During upgrade I have the following errors just after the line "System config value trusted_proxies => 12 set to string ::1"
✓ redis is configured
✓ push server is receiving redis messages
✓ push server can load mount info from database
🗴 push server can't connect to the Nextcloud server
error sending request for url (https://10.8.6.100/index.php/apps/notify_push/test/cookie): error trying to connect: invalid dnsname: error trying to connect: invalid dnsname: invalid dnsname
Abort
Clean up...
Rolling back to backup /var/www/nextcloud-bkp_20210905_1630827743-20.0.2.2.tar.gz...
{"reqId":"g2uhEBMHYLKFdYG1047b","level":2,"time":"2021-09-05T07:45:50+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"Temporary directory /var/www/nextcloud/data/tmp is not present or writable","userAgent":"--","version":"21.0.4.1"}
{"reqId":"g2uhEBMHYLKFdYG1047b","level":2,"time":"2021-09-05T07:45:50+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"Temporary directory /var/www/nextcloud/data/tmp is not present or writable","userAgent":"--","version":"21.0.4.1"}
check free space...
extracting backup file /var/www/nextcloud-bkp_20210905_1630827743-20.0.2.2.tar.gz...
restore files...
restore database...
No datadir found in backup
Maintenance mode disabled
Starting scan for user 1 out of 1 (ncp)
+---------+-------+--------------+
| Folders | Files | Elapsed time |
+---------+-------+--------------+
| 2 | 0 | 00:00:00 |
+---------+-------+--------------+
System config value tempdirectory set to string /var/www/nextcloud/data/tmp
System config value logfile set to string /var/www/nextcloud/data/nextcloud.log
System config value trusted_domains => 11 set to string 176.78.117.244
System config value trusted_domains => 1 set to string 10.8.6.100
Scanning AppData for files
+---------+-------+--------------+
| Folders | Files | Elapsed time |
+---------+-------+--------------+
| 5 | 4 | 00:00:00 |
+---------+-------+--------------+
Cleanup...
Rollback successful. Nothing was updated
Done. Press any key...
The text was updated successfully, but these errors were encountered: