Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling far down makes pictures stop loading on the bottom part of the screen/view #214

Closed
simeneriks1 opened this issue Feb 28, 2020 · 19 comments
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working high High priority

Comments

@simeneriks1
Copy link

Describe the bug
Scrolling down in the photos app in NC18 too far, stop loading pictures and scrolling is impossible.
Screenshot 2020-02-28 at 11 11 20

To Reproduce
Steps to reproduce the behavior:

  1. Have more than 500-600 pictures
  2. Scroll all the way as far as you can
  3. Watch it stop because the bottom threshold is moving upwards, and therefore not loading more pictures

Expected behavior
I want the full screen to be filled up with pictures

Screenshots
Here i have scrolled further down. The bottom threshold for showing the pictures is faaar up.
If I keep scrolling i can't see any pictures.
image

Desktop (please complete the following information):

  • OS: Chrome OS, Windows, Linux
  • Browser Chrome 81

Browser log
No logs

Additional context
It only shows bad when scrolling, on top it is all normal.

@simeneriks1 simeneriks1 added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Feb 28, 2020
@skjnldsv
Copy link
Member

Hello!
I will need your browser console log to investigate this issue.
Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.

How to access your browser console (Click to expand)

Chrome

  • Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
  • Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “console” tab.

Safari

  • Press CMD + ALT + I to open the Web Inspector.
  • See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

IE9

  1. Press F12 to open the developer tools.
  2. Click the “console” tab.

Firefox

  • Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
  • or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “console” tab.

Opera

  1. Press CTRL + SHIFT + I to open Dragonfly.
  2. Click on the “console” tab.

@skjnldsv skjnldsv added the needs info Not enough information provided label Feb 28, 2020
@simeneriks1
Copy link
Author

simeneriks1 commented Mar 1, 2020

I think you misunderstand the bug - There is no output in the console as there are no crashes/errors/code related issues in this case.
What happens is that I scroll and scroll, and the threshold for showing pictures at the bottom is moving upwards, so when i scroll, less and less pictures are visible. At some point it will not let me scroll, because the app simply doesn't cache in more pictures on the bottom, and the scrolling stops. If i scroll slightly up, and really fast down again, i can manage to load 1-2 rows more of pictures.
I can do an effort and try to recreate this on a new installation.

I tried several times but there are no console output to show in this report.

I can also record a video to show you the issue, if that helps :)

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2020

The console log is supposed to show some debug informations.
This is not always about errors or crashes ;)

Capture d’écran_2020-03-02_08-17-40

@simeneriks1
Copy link
Author

Alright, sorry about that!

Here is a screenshot

image

Errors I see is mostly connected to other apps or issues. I hope it is of help :)

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2020

Ah right, on the small dropdown with log level, please also enable verbose :)
image

@dennorske
Copy link

image

image

There you go :) Stops at page 24, can't scroll further unless I change the aspect ratio of my browser (resizing so the grid changes)

I scrolled up so you could see the errors that popped up. Also while scrolling, I get a lot of the forced reflow messages

@skjnldsv
Copy link
Member

skjnldsv commented Mar 4, 2020

What happens if you scroll up on the page then down again?

@dennorske
Copy link

dennorske commented Mar 4, 2020 via email

@simeneriks1
Copy link
Author

I manage to reproduce the problem on a fresh install, but i need like 3k pictures to make it very noticeable.

I suspect the grid calculations are off by a few pixels, and this just continues to add up as you scroll down.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of high High priority and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. needs info Not enough information provided labels Mar 13, 2020
@simeneriks1
Copy link
Author

Hi, any news on this or do you need more info?

@skjnldsv
Copy link
Member

Unfortunately I just need time :(

@Mikescops
Copy link
Member

This was indeed an incremental shift caused by the virtual grid computation.

With the new grid this should be fixed. See #468

@simeneriks1
Copy link
Author

I am still facing the same issue.

The update fixed that the grid does not move slightly upwards, but it still stops loading pictures after a certain amount of scroll.

I can recreate this on a brand new installation with enough pictures in it, I have around 800 and i get down to about 500 pictures before it doesn't let me scroll more. Was this tested before it was pushed in production?

@Mikescops
Copy link
Member

Are you trying on the master branch?

@simeneriks1
Copy link
Author

Ahhhh I am very sorry about that. I didn't realize that "To be released" was tagged on the PR - I blindly assumed it was pushed to production.

I'll give it a new try when the app has been updated. Sorry again for my ignorance, have a nice day.
Simen

@Mikescops
Copy link
Member

This will be for Nextcloud 21 indeed 😄

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Nov 12, 2020
@skjnldsv
Copy link
Member

I'll give it a new try when the app has been updated. Sorry again for my ignorance, have a nice day.

No worries! Thank you very much for your interest, we'll eager for you to try the upcoming version! @Mikescops did an insane job! 🎉 🚀

@guystreeter
Copy link

guystreeter commented Jun 30, 2021

Can you please verify the fix for this issue is supposed to be in version 21? I'm running the current docker image, 21.0.2, and the Photos view hangs if I scroll it at all. I've left it sitting with the busy indicator for half an hour and it never completes. I get the same results on Firefox and Chrome (both on Linux).
It appears to be something timing-related, because if I have the browser console open, it scrolls properly one time. Then it leaves some random thumbnails blank when I scroll around.
I just found issue #748 which seems to describe my problem. I apparently didn't search for just the right terms :)

@dennorske
Copy link

Yep this issue in specific is fixed! :)

I hope you solve your problem though, good luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working high High priority
Projects
None yet
Development

No branches or pull requests

5 participants