-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue when loading direct editing #2874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Waiting for new test to fail before pushing the fix |
Passing run #211 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
/backport to stable26 |
juliusknorr
added
bug
Something isn't working
3. to review
Ready to be reviewed
and removed
backport-request
labels
Mar 23, 2023
juliusknorr
changed the title
tests(cypress): Add basic test for direct editing
Fix issue when loading direct editing
Mar 23, 2023
mejo-
approved these changes
Mar 29, 2023
@juliushaertl Could you build a new release, it would be nice if this bug would be fixed :) |
Yes, there are a few more fixes in the pipeline to get merged but new release is expected soon. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2873
Regression from #2258 as the old template changed the identifier of the config value passed to the frontend from direct to directEdit