Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when loading direct editing #2874

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Fix issue when loading direct editing #2874

merged 2 commits into from
Mar 29, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 23, 2023

Fixes #2873

Regression from #2258 as the old template changed the identifier of the config value passed to the frontend from direct to directEdit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Waiting for new test to fail before pushing the fix

@cypress
Copy link

cypress bot commented Mar 23, 2023

Passing run #211 ↗︎

0 25 0 0 Flakiness 0

Details:

tests(cypress): Add basic test for direct editing
Project: Richdocuments Commit: fc9d675a9f
Status: Passed Duration: 03:53 💡
Started: Mar 23, 2023 12:34 PM Ended: Mar 23, 2023 12:38 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

/backport to stable26

@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed and removed backport-request labels Mar 23, 2023
@juliusknorr juliusknorr changed the title tests(cypress): Add basic test for direct editing Fix issue when loading direct editing Mar 23, 2023
@juliusknorr juliusknorr marked this pull request as ready for review March 23, 2023 20:28
@jakobroehrl
Copy link

@juliushaertl Could you build a new release, it would be nice if this bug would be fixed :)

@juliusknorr
Copy link
Member Author

Yes, there are a few more fixes in the pipeline to get merged but new release is expected soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open office documents after update to NC 26
3 participants