From 4e9facdb4f4846dda554bf0b9a84d451007e020d Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Wed, 17 Apr 2024 17:38:41 +0200 Subject: [PATCH] feat(cypress): Add tests for files sidebar Signed-off-by: Ferdinand Thiessen --- cypress/e2e/files/files-sidebar.cy.ts | 94 +++++++++++++++++++++++++++ cypress/support/commands.ts | 6 +- 2 files changed, 99 insertions(+), 1 deletion(-) create mode 100644 cypress/e2e/files/files-sidebar.cy.ts diff --git a/cypress/e2e/files/files-sidebar.cy.ts b/cypress/e2e/files/files-sidebar.cy.ts new file mode 100644 index 0000000000000..316116a25e401 --- /dev/null +++ b/cypress/e2e/files/files-sidebar.cy.ts @@ -0,0 +1,94 @@ +/** + * @copyright Copyright (c) 2024 Ferdinand Thiessen + * + * @author Ferdinand Thiessen + * + * @license AGPL-3.0-or-later + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +import type { User } from '@nextcloud/cypress' +import { getRowForFile, navigateToFolder, triggerActionForFile } from './FilesUtils' + +describe('Files: Sidebar', { testIsolation: true }, () => { + let user: User + let fileId: number = 0 + + beforeEach(() => cy.createRandomUser().then(($user) => { + user = $user + + cy.mkdir(user, '/folder') + cy.uploadContent(user, new Blob([]), 'text/plain', '/file').then((response) => { + fileId = Number.parseInt(response.headers['oc-fileid'] ?? '0') + }) + cy.login(user) + })) + + it('opens the sidebar', () => { + cy.visit('/apps/files') + getRowForFile('file').should('be.visible') + + triggerActionForFile('file', 'details') + + cy.get('[cy-data-sidebar]').should('be.visible') + }) + + it('changes the current fileid', () => { + cy.visit('/apps/files') + getRowForFile('file').should('be.visible') + + triggerActionForFile('file', 'details') + + cy.get('[cy-data-sidebar]').should('be.visible') + cy.url().should('contain', `apps/files/files/${fileId}`) + }) + + it('closes the sidebar on delete', () => { + cy.visit('/apps/files') + getRowForFile('file').should('be.visible') + + // open the sidebar + triggerActionForFile('file', 'details') + // validate it is open + cy.get('[cy-data-sidebar]').should('be.visible') + + triggerActionForFile('file', 'delete') + cy.get('[cy-data-sidebar]').should('not.exist') + }) + + it('changes the fileid on delete', () => { + cy.uploadContent(user, new Blob([]), 'text/plain', '/folder/other').then((response) => { + const otherFileId = Number.parseInt(response.headers['oc-fileid'] ?? '0') + cy.login(user) + cy.visit('/apps/files') + + getRowForFile('folder').should('be.visible') + navigateToFolder('folder') + getRowForFile('other').should('be.visible') + + // open the sidebar + triggerActionForFile('other', 'details') + // validate it is open + cy.get('[cy-data-sidebar]').should('be.visible') + cy.url().should('contain', `apps/files/files/${otherFileId}`) + + triggerActionForFile('other', 'delete') + cy.get('[cy-data-sidebar]').should('not.exist') + // Ensure the URL is changed + cy.url().should('not.contain', `apps/files/files/${otherFileId}`) + }) + }) +}) diff --git a/cypress/support/commands.ts b/cypress/support/commands.ts index 6e43c5e85cb73..cbc18ec24dc4d 100644 --- a/cypress/support/commands.ts +++ b/cypress/support/commands.ts @@ -2,7 +2,9 @@ * SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -/* eslint-disable n/no-unpublished-import */ +// eslint-disable-next-line n/no-extraneous-import +import type { AxiosResponse } from 'axios' + import axios from '@nextcloud/axios' import { addCommands, User } from '@nextcloud/cypress' import { basename } from 'path' @@ -16,10 +18,12 @@ addCommands() declare global { // eslint-disable-next-line @typescript-eslint/no-namespace namespace Cypress { + // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unused-vars interface Chainable { /** * Enable or disable a given user */ + // eslint-disable-next-line @typescript-eslint/no-explicit-any enableUser(user: User, enable?: boolean): Cypress.Chainable>, /**