From d31bc9fa345900330eb036597ed8303a091cb123 Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Mon, 14 Feb 2022 16:14:57 +0100 Subject: [PATCH 1/2] Disable bulk upload by not advertising it It has been reported broken on many instances. Disable it for now until it can be fixed. Signed-off-by: Vincent Petry --- apps/dav/lib/Capabilities.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/dav/lib/Capabilities.php b/apps/dav/lib/Capabilities.php index ce60bccfd0b54..2f0378dd56a40 100644 --- a/apps/dav/lib/Capabilities.php +++ b/apps/dav/lib/Capabilities.php @@ -29,7 +29,8 @@ public function getCapabilities() { return [ 'dav' => [ 'chunking' => '1.0', - 'bulkupload' => '1.0', +// disabled because of https://github.com/nextcloud/desktop/issues/4243 +// 'bulkupload' => '1.0', ] ]; } From e1e003f5693a82a7bf6d8a3be480d44dd76df8f6 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Tue, 15 Feb 2022 07:14:14 +0100 Subject: [PATCH 2/2] Also comment out in test Signed-off-by: Joas Schilling --- apps/dav/lib/Capabilities.php | 4 ++-- apps/dav/tests/unit/CapabilitiesTest.php | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/apps/dav/lib/Capabilities.php b/apps/dav/lib/Capabilities.php index 2f0378dd56a40..41d1b98358740 100644 --- a/apps/dav/lib/Capabilities.php +++ b/apps/dav/lib/Capabilities.php @@ -29,8 +29,8 @@ public function getCapabilities() { return [ 'dav' => [ 'chunking' => '1.0', -// disabled because of https://github.com/nextcloud/desktop/issues/4243 -// 'bulkupload' => '1.0', + // disabled because of https://github.com/nextcloud/desktop/issues/4243 + // 'bulkupload' => '1.0', ] ]; } diff --git a/apps/dav/tests/unit/CapabilitiesTest.php b/apps/dav/tests/unit/CapabilitiesTest.php index 399467f6ed8dd..7abfd08854b7d 100644 --- a/apps/dav/tests/unit/CapabilitiesTest.php +++ b/apps/dav/tests/unit/CapabilitiesTest.php @@ -35,7 +35,8 @@ public function testGetCapabilities() { $expected = [ 'dav' => [ 'chunking' => '1.0', - 'bulkupload' => '1.0', + // disabled because of https://github.com/nextcloud/desktop/issues/4243 + // 'bulkupload' => '1.0', ], ]; $this->assertSame($expected, $capabilities->getCapabilities());