Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio-/video streaming should have no download-button #10927

Closed
berberisD opened this issue Aug 29, 2018 · 9 comments
Closed

audio-/video streaming should have no download-button #10927

berberisD opened this issue Aug 29, 2018 · 9 comments

Comments

@berberisD
Copy link

Steps to reproduce

  1. share audio or video using the public link
  2. open the link

Expected behaviour

sharing for "streaming" would be much better without download button (copyrights in some cases)
just like "youtube" - a button to start the stream would be enough
there should be an additional sharing-option like "only viewing online"

Actual behaviour

you will see download-button in the middle of the site and a second one in the top

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #4902 (Download button on share view has strange color), #10111 (Audio player should have controls like video player), #10726 (Video streaming results in multiple "file downloaded" activity records), #6016 (Disable mass download button on shares), and #9806 (Downloading a publicly shared calendar via the Download Button fails).

@berberisD
Copy link
Author

berberisD commented Sep 25, 2018

I think the issues the nextcloud-bot found are not related to this case.
To clarify i have two screenshots here:

screen2
So putting a tick at hide-download-button

screen1
would deliver a page without explicit downloadbuttons.

Would be great, if this function could be installed :-)

@MorrisJobke
Copy link
Member

cc @rullzer

@timmersr
Copy link

Checking "Hide download" will not only hide download options, but also prevent video playback in NC15 RC1.
1

@berberisD
Copy link
Author

berberisD commented Nov 28, 2018

So the new "Hide download" in NC15 is planned to prevent the download-functionality in general.
Whereas "Hide download buttons" is just to visually hide the button for downloads.
With some tec skills its possible to download of course - but not so obvious anymore.

@MorrisJobke
Copy link
Member

Fixed by #12531 and #11898

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 29, 2018
@MorrisJobke
Copy link
Member

Checking "Hide download" will not only hide download options, but also prevent video playback in NC15 RC1.

Separate issue.

@mattx388
Copy link

mattx388 commented Jun 24, 2019

Checking "Hide download" will not only hide download options, but also prevent video playback in NC15 RC1.

Separate issue.

But this "Separate issue" will be fixed in the future ?
For me it is important bug.

@Shishadampfer
Copy link

Hi all
I'm pretty new to nextcloud and the gallery app. Currently using the nextcloud version 16.0.5 with gallery app version 18.3.0.
While testing I figured out that the download buttons still keep showing up, although I did check "hide download" for the specific share.
While searching for a solution to remove the download option from the gallery I came across this thread.

Any solution yet available or planned to be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants