Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC14.0.0.19 Web ui folder-navigation broken for users with space in username #11117

Closed
JSoko opened this issue Sep 8, 2018 · 5 comments · Fixed by #11151
Closed

NC14.0.0.19 Web ui folder-navigation broken for users with space in username #11117

JSoko opened this issue Sep 8, 2018 · 5 comments · Fixed by #11151
Assignees
Labels
3. to review Waiting for reviews bug high

Comments

@JSoko
Copy link
Member

JSoko commented Sep 8, 2018

Steps to reproduce

For Users without space in the username it opens the folder and links to
https://next.cloud/index.php/apps/files?dir=//Testfolder

Expected behaviour

It should open the folder
should link to https://next.cloud/index.php/apps/files?dir=//Testfolder

Actual behaviour

It doesn't open the folder
https://next.cloud/index.php/apps/files?dir=/Test%20User/Testfolder

Server configuration detail

Operating system: Linux 4.15.0-33-generic #36-Ubuntu SMP Wed Aug 15 16:00:05 UTC 2018 x86_64

Webserver: Apache/2.4.29 (Ubuntu) (apache2handler)

Database: mysql 10.2.16

PHP version:

7.2.7-0ubuntu0.18.04.2
Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, sodium, session, standard, apache2handler, mysqlnd, PDO, xml, apcu, apc, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, igbinary, imagick, intl, json, ldap, exif, mysqli, pdo_mysql, Phar, posix, readline, redis, shmop, SimpleXML, smbclient, soap, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlrpc, xmlwriter, xsl, zip, libsmbclient, Zend OPcache

Nextcloud version: 14.0.0 - 14.0.0.19

Updated from an older Nextcloud/ownCloud or fresh install: older Nextcloud

Where did you install Nextcloud from: NC VM

Signing status

Array
(
)

List of activated apps
Enabled:
 - activity: 2.7.0
 - admin_audit: 1.4.0
 - admin_notifications: 1.0.2
 - announcementcenter: 3.3.0
 - apporder: 0.5.0
 - bookmarks: 0.13.0
 - calendar: 1.6.2
 - cloud_federation_api: 0.0.1
 - comments: 1.4.0
 - contacts: 2.1.6
 - dav: 1.6.0
 - deck: 0.4.1
 - external: 3.1.0
 - federatedfilesharing: 1.4.0
 - files: 1.9.0
 - files_downloadactivity: 1.3.0
 - files_pdfviewer: 1.3.2
 - files_sharing: 1.6.2
 - files_texteditor: 2.6.0
 - files_trashbin: 1.4.1
 - files_versions: 1.7.1
 - files_videoplayer: 1.3.0
 - impersonate: 1.1.0
 - issuetemplate: 0.4.0
 - logreader: 2.0.0
 - lookup_server_connector: 1.2.0
 - mindmaps: 0.1.0
 - news: 12.0.4
 - nextcloud_announcements: 1.3.0
 - notes: 2.4.1
 - notifications: 2.2.1
 - oauth2: 1.2.1
 - ownbackup: 18.8.1
 - password_policy: 1.4.0
 - piwik: 0.4.1
 - polls: 0.8.3
 - previewgenerator: 1.1.0
 - provisioning_api: 1.4.0
 - quota_warning: 1.3.0
 - radio: 0.6.2
 - serverinfo: 1.4.0
 - sharebymail: 1.4.0
 - sharerenamer: 2.1.0
 - socialsharing_email: 1.0.4
 - spreed: 4.0.0
 - support: 1.0.0
 - survey_client: 1.2.0
 - systemtags: 1.4.0
 - tasks: 0.9.7
 - theming: 1.5.0
 - twofactor_backupcodes: 1.3.1
 - updatenotification: 1.4.1
 - user_usage_report: 1.1.0
 - workflowengine: 1.4.0
Disabled:
 - accessibility
 - encryption
 - federation
 - files_external
 - files_rightclick
 - firstrunwizard
 - gallery
 - ocsms
 - user_external
 - user_ldap

Configuration (config/config.php)
{
    "simpleSignUpLink.shown": true,
    "loglevel": 2,
    "maintenance": false,
    "theme": "",
    "integrity.check.disabled": false,
    "default_language": "de_DE",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "logtimezone": "Europe\/Berlin",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "log_rotate_size": "10485760",
    "activity_expire_days": 33,
    "trusted_domains": [
        "localhost",
        "192.168.1.234",
        "***REMOVED SENSITIVE VALUE***",
        "***REMOVED SENSITIVE VALUE***"
    ],
    "htaccess.RewriteBase": "\/",
    "preview_max_x": 500,
    "preview_max_y": 500,
    "preview_max_scale_factor": 2,
    "trashbin_retention_obligation": "auto, 10",
    "versions_retention_obligation": "auto, 21",
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "overwrite.cli.url": "https:\/\/of99.net\/",
    "dbtype": "mysql",
    "version": "14.0.0.19",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "mail_smtpmode": "smtp",
    "memcache.local": "\\OC\\Memcache\\Redis",
    "filelocking.enabled": true,
    "memcache.distributed": "\\OC\\Memcache\\Redis",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 0,
        "timeout": 0,
        "dbindex": 0,
        "password": "***REMOVED SENSITIVE VALUE***"
    },
    "updater.release.channel": "production",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauthtype": "LOGIN",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpsecure": "tls",
    "instanceid": "***REMOVED SENSITIVE VALUE***"
}

Are you using external storage, if yes which one: no

Are you using encryption: false

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36

Operating system: Windows 10

Logs

Browser log
PROPFIND
https://next.cloud/remote.php/dav/files/Test%20User/remote.php/dav/files/Test%20User/TestFolder
Status Code:404

Answer:
XHRPROPFINDhttps://next.cloud/remote.php/dav/files/Test%20User/[HTTP/1.1 207 Multi-Status 52ms] 
KopfzeilenCookiesParameterAntwortZeitAufruflisteAntwortinhaltx1<?xml version="1.0"?>2<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns"><d:response><d:href>/remote.php/dav/files/Test%20User/</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:40 GMT</d:getlastmodified><d:getetag>&quot;5b93adb83b81a&quot;</d:getetag><d:resourcetype><d:collection/></d:resourcetype><oc:fileid>3899469</oc:fileid><oc:permissions>RGDNVCK</oc:permissions><oc:size>10600101</oc:size><nc:has-preview>false</nc:has-preview><nc:mount-type></nc:mount-type><nc:is-encrypted>0</nc:is-encrypted><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">31</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><d:getcontenttype/><d:getcontentlength/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/Documents/</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:26 GMT</d:getlastmodified><d:getetag>&quot;5b93adaad60d1&quot;</d:getetag><d:resourcetype><d:collection/></d:resourcetype><oc:fileid>3899478</oc:fileid><oc:permissions>RGDNVCK</oc:permissions><oc:size>2607827</oc:size><nc:has-preview>false</nc:has-preview><nc:mount-type></nc:mount-type><nc:is-encrypted>0</nc:is-encrypted><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">31</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><d:getcontenttype/><d:getcontentlength/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/Nextcloud%20Community.jpeg</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:25 GMT</d:getlastmodified><d:getetag>&quot;c181b8233a7f85aaa8bd1d22b0cb8d25&quot;</d:getetag><d:getcontenttype>image/jpeg</d:getcontenttype><d:resourcetype/><oc:fileid>3899470</oc:fileid><oc:permissions>RGDNVW</oc:permissions><oc:size>598877</oc:size><d:getcontentlength>598877</d:getcontentlength><nc:has-preview>true</nc:has-preview><nc:mount-type></nc:mount-type><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">19</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><nc:is-encrypted/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/Nextcloud%20Manual.pdf</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:26 GMT</d:getlastmodified><d:getetag>&quot;e429fb9399369473e5951062512e16e0&quot;</d:getetag><d:getcontenttype>application/pdf</d:getcontenttype><d:resourcetype/><oc:fileid>3899477</oc:fileid><oc:permissions>RGDNVW</oc:permissions><oc:size>4533931</oc:size><d:getcontentlength>4533931</d:getcontentlength><nc:has-preview>false</nc:has-preview><nc:mount-type></nc:mount-type><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">19</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><nc:is-encrypted/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/Nextcloud.mp4</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:26 GMT</d:getlastmodified><d:getetag>&quot;2640417ed5178caff1b669ef3750d922&quot;</d:getetag><d:getcontenttype>video/mp4</d:getcontenttype><d:resourcetype/><oc:fileid>3899476</oc:fileid><oc:permissions>RGDNVW</oc:permissions><oc:size>462413</oc:size><d:getcontentlength>462413</d:getcontentlength><nc:has-preview>false</nc:has-preview><nc:mount-type></nc:mount-type><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">19</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><nc:is-encrypted/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/Nextcloud.png</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:26 GMT</d:getlastmodified><d:getetag>&quot;344d4862dc09b78386f5bdf115a1d8fd&quot;</d:getetag><d:getcontenttype>image/png</d:getcontenttype><d:resourcetype/><oc:fileid>3899475</oc:fileid><oc:permissions>RGDNVW</oc:permissions><oc:size>37042</oc:size><d:getcontentlength>37042</d:getcontentlength><nc:has-preview>true</nc:has-preview><nc:mount-type></nc:mount-type><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">19</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><nc:is-encrypted/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/Photos/</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:25 GMT</d:getlastmodified><d:getetag>&quot;5b93ada9c73c5&quot;</d:getetag><d:resourcetype><d:collection/></d:resourcetype><oc:fileid>3899471</oc:fileid><oc:permissions>RGDNVCK</oc:permissions><oc:size>2360011</oc:size><nc:has-preview>false</nc:has-preview><nc:mount-type></nc:mount-type><nc:is-encrypted>0</nc:is-encrypted><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">31</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><d:getcontenttype/><d:getcontentlength/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response><d:response><d:href>/remote.php/dav/files/Test%20User/TestFolder/</d:href><d:propstat><d:prop><d:getlastmodified>Sat, 08 Sep 2018 11:08:40 GMT</d:getlastmodified><d:getetag>&quot;5b93adb835675&quot;</d:getetag><d:resourcetype><d:collection/></d:resourcetype><oc:fileid>3899488</oc:fileid><oc:permissions>RGDNVCK</oc:permissions><oc:size>0</oc:size><nc:has-preview>false</nc:has-preview><nc:mount-type></nc:mount-type><nc:is-encrypted>0</nc:is-encrypted><x1:share-permissions xmlns:x1="http://open-collaboration-services.org/ns">31</x1:share-permissions><oc:tags/><oc:favorite>0</oc:favorite><oc:comments-unread>0</oc:comments-unread><oc:owner-id>Test User</oc:owner-id><oc:owner-display-name>TestUser</oc:owner-display-name><oc:share-types/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat><d:propstat><d:prop><d:getcontenttype/><d:getcontentlength/></d:prop><d:status>HTTP/1.1 404 Not Found</d:status></d:propstat></d:response></d:multistatus>
Nextcloud log
Nothing related in nextcloud.log
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8429 (Username with space), #2693 (More space for navigation text), #2086 (Show progress/spinner when create/delete user in web UI), #8698 (need a group or folder for all user), and #1173 (Upload to shared folder broken).

@JSoko
Copy link
Member Author

JSoko commented Sep 10, 2018

Can also replicate this bug with @jasonbayton 's Demo Instance!

https://j.son.bz/nextcloud14

Just create a user with a blank in his name, 'Test User' logout as admin login as 'Test User' and try to open the Folder Documents.
It doesn't work! It links to
https://demo14.nextcloud.bayton.org/index.php/apps/files?dir=/remote.php/dav/files/Test%20user/Documents

@JSoko JSoko changed the title NC14 Web ui folder-navigation broken for users with space in username NC14.0.0.19 Web ui folder-navigation broken for users with space in username Sep 10, 2018
@jospoortvliet jospoortvliet removed their assignment Sep 10, 2018
@jospoortvliet
Copy link
Member

I can verify this on a local instance, too.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of high labels Sep 10, 2018
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 10, 2018
@icewind1991
Copy link
Member

Fix is here: #11152

@JSoko
Copy link
Member Author

JSoko commented Sep 11, 2018

Thank You @icewind1991
The fix works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants