Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend validation for Add User form #11584

Closed
pixelipo opened this issue Oct 3, 2018 · 7 comments
Closed

Frontend validation for Add User form #11584

pixelipo opened this issue Oct 3, 2018 · 7 comments
Labels

Comments

@pixelipo
Copy link
Contributor

pixelipo commented Oct 3, 2018

New User form badly needs some frontend validation to match the PHP stuff. While pull request #11581 I had to type in the entire form several times because it would empty it up after failing to comply with password requirements:

  1. "password too short" - that error has frontend validation, but it's only displayed as a popover on hover, so it's hard to discover
  2. "password too common" - resets the form:
    image
  3. "user already exists" - same as ⬆️
    needs uppercase, lowercase, the list goes on.

What should happen:

  1. errors should show where they occur
  2. location of the error should be highlighted
  3. form should not be cleared
    image

@nextcloud/designers sorry for my bad "screenshot", but what do you think? Should notifications stay on top (with an "x") to keep the consistency with the rest of the NC?

@pixelipo pixelipo added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: users and groups labels Oct 3, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8098 (Adding new user fails), #5114 (NC12, Adding user not possible), #4634 (Add ability for admin to hide folders from users ), #9962 (Added icons to users list and improved design), and #11417 (Add back the total used space per user).

@MorrisJobke
Copy link
Member

New User form badly needs some frontend validation to match the PHP stuff.

And also inline the errors from the backend, because the notification at the top is something we should not use anymore designwise.

@jancborchardt
Copy link
Member

The errors like "Password too short" should be shown using the tooltip() function so the interface is not moved around and it calls enough attention to itself.

(Also, we never ever use italic text in an interface. :)

@pixelipo
Copy link
Contributor Author

pixelipo commented Oct 3, 2018

That sounds good @jancborchardt - important thing is that these are actually visible for n seconds

@jancborchardt
Copy link
Member

Or until the next interaction? (Or until it’s long enough?) Purely time-based messages are always a pain when you don’t look, or they are gone too quick – which is why we are trying to phase out the top showNotification().

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of enhancement and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 30, 2019
@szaimen
Copy link
Contributor

szaimen commented May 20, 2021

I am going to close this since there doesn't seem to be a lot of interest and no respond since over 2 years. Please reopen if you still want to implement this.

@szaimen szaimen closed this as completed May 20, 2021
@szaimen
Copy link
Contributor

szaimen commented May 27, 2021

This will be much improved with #23529
So please create a new issue if there should be something to improve. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants