Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning for non-existing LDAP users #1470

Closed
MorrisJobke opened this issue Sep 20, 2016 · 5 comments
Closed

Avoid warning for non-existing LDAP users #1470

MorrisJobke opened this issue Sep 20, 2016 · 5 comments
Assignees
Labels
3. to review Waiting for reviews enhancement feature: ldap papercut Annoying recurring issue with possibly simple fix.

Comments

@MorrisJobke
Copy link
Member

MorrisJobke commented Sep 20, 2016

  • use user_ldap
  • try to login a user that doesn't exist on LDAP nor in the internal DB
  • expected: no warning level message (at most a message of level debug or info)
  • actual:
{
    "Code": 0,
    "Exception": "Exception",
    "File": "apps/user_ldap/lib/User_LDAP.php",
    "Line": 117,
    "Message": "No user available for the given login name on ldap://server:389",
    "Trace": "
        #0 apps/user_ldap/lib/User_LDAP.php(133): OCA\\User_LDAP\\User_LDAP->getLDAPUserByLoginName('admin')
        #1 lib/private/User/Manager.php(201): OCA\\User_LDAP\\User_LDAP->checkPassword(*** sensitive parameters replaced ***)
        #2 core/Controller/LoginController.php(214): OC\\User\\Manager->checkPassword(*** sensitive parameters replaced ***)
        #3 [internal function]: OC\\Core\\Controller\\LoginController->tryLogin(*** sensitive parameters replaced ***)
        #4 lib/private/AppFramework/Http/Dispatcher.php(160): call_user_func_array(Array, Array)
        #5 lib/private/AppFramework/Http/Dispatcher.php(90): OC\\AppFramework\\Http\\Dispatcher->executeController(Object(OC\\Core\\Controller\\LoginController), 'tryLogin')
        #6 lib/private/AppFramework/App.php(111): OC\\AppFramework\\Http\\Dispatcher->dispatch(Object(OC\\Core\\Controller\\LoginController), 'tryLogin')
        #7 lib/private/AppFramework/Routing/RouteActionHandler.php(47): OC\\AppFramework\\App::main('LoginController', 'tryLogin', Object(OC\\AppFramework\\DependencyInjection\\DIContainer), Array)
        #8 [internal function]: OC\\AppFramework\\Routing\\RouteActionHandler->__invoke(Array)
        #9 lib/private/Route/Router.php(293): call_user_func(Object(OC\\AppFramework\\Routing\\RouteActionHandler), Array)
        #10 lib/base.php(983): OC\\Route\\Router->match('/login')
        #11 index.php(48): OC::handleRequest()
        #12 {main}
    "
}

URL: /login?user=admin, app: user_ldap, log level: 3

cc @blizzz

@MorrisJobke MorrisJobke added enhancement feature: ldap papercut Annoying recurring issue with possibly simple fix. labels Sep 20, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Sep 20, 2016
@blizzz
Copy link
Member

blizzz commented Sep 29, 2016

@MorrisJobke wasn't it the debug info that you have wanted once quite a while ago?

@MorrisJobke
Copy link
Member Author

@MorrisJobke wasn't it the debug info that you have wanted once quite a while ago?

Correct, but not in the log level 3 (warning).

@blizzz
Copy link
Member

blizzz commented Sep 29, 2016

so, removing it completely or downgrading to debug?

My bad, i somehow thought you wanted it removed. Sorry.

@blizzz blizzz self-assigned this Sep 29, 2016
@MorrisJobke
Copy link
Member Author

@blizzz Is this easy to accomplish?

@blizzz
Copy link
Member

blizzz commented Nov 29, 2016

Here you go #2409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: ldap papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

2 participants