Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud.occ config:list prints object storage credentials #17659

Closed
daniel7558 opened this issue Oct 23, 2019 · 0 comments · Fixed by #17696
Closed

nextcloud.occ config:list prints object storage credentials #17659

daniel7558 opened this issue Oct 23, 2019 · 0 comments · Fixed by #17696
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@daniel7558
Copy link

The nextcloud.occ config:list outputs the object storage credentials in plaintext

The Issue Debugging Script relies on this command and this can lead to posting access credentials publicly.

Steps to reproduce

  1. Setup nextcloud with object storage as the primary storage medium
  2. nextcloud.occ config:list

Expected behaviour

Credentials get removed/replaced with ***REMOVED SENSITIVE VALUE*** as it is done for the passwordsalt and secret field (amoung others).

Actual behaviour

Key and Secret are shown.

Output

        "objectstore": {
            "class": "OC\\Files\\ObjectStore\\S3",
            "arguments": {
                "bucket": "mydata.nextcloud.myDomain.tld",
                "region": "eu-central-1",
                "autocreate": true,
                "key": "<Key was included in plaintext>",
                "secret": "<Secret was included in plaintext>",
                "use_ssl": true
            }
        },
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",

Issue first opend for the debugging script in nextcloud-snap, however it should fit better here.
nextcloud-snap/nextcloud-snap#1150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant