Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only select files filtered by search #2075

Closed
raimund-schluessler opened this issue Nov 10, 2016 · 4 comments
Closed

Only select files filtered by search #2075

raimund-schluessler opened this issue Nov 10, 2016 · 4 comments

Comments

@raimund-schluessler
Copy link
Member

Steps to reproduce

  1. Have a folder with various files.
    screen shot 2016-11-10 at 13 24 50

  2. Search within the folder (e.g. search for "mp3")
    screen shot 2016-11-10 at 13 24 59

  3. Select all files using the "select_all_files" checkbox.
    screen shot 2016-11-10 at 13 25 07

Expected behaviour

I would expect that only the files shown after searching are selected. This would e.g. simplify downloading only certain files.

Actual behaviour

Instead of only selecting the 3 shown files, all files within the folder (also the ones filtered out by searching) are selected.

Nextcloud version: 10.0.1

I searched for similar issues and found this one: #1274 However, I think this issue here is a bit different as this is not about group actions. Correct me if I'm wrong.

@icewind1991 @jancborchardt

@jasonbayton
Copy link
Member

I can also add when using Shift+click to select multiple files, the same sort of thing happens; it selects far more than it should presumably as it's selecting files between those filtered.

@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Jun 4, 2017
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of feature: search labels Jun 4, 2017
@Schmuuu
Copy link

Schmuuu commented Jul 13, 2017

For me this is actually a serious bug. I was just going to open a new issue (but found this one then), because the following happened to me:

With every photo I take on my smartphone there are additional files (*.nar, *.thm, ...) created and all this files together with the photos itself are then automatically uploaded to NC.
When I wanted to clean up my upload folder on the server, I performed a search for the specific file extensions and hit the "select all" checkbox not knowing about this bug. I only knew I have a few thousands photos on my server, but no exact number and when it read "selected 3147 files" I thought, this could be right.

Well, after hitting delete, I found my Photo folder to be completely empty. Older photos have been deleted in the trash bin as I exceeded the Quota limit. I got a backup elsewhere, but that wasn't fun and rather a big shock at first.

Is there a chance to have this fixed earlier than NC13?
While the current behavior is everything but obvious I can only hope it doesn't happen to other users, who don't take backups serious.

@raimund-schluessler raimund-schluessler removed the papercut Annoying recurring issue with possibly simple fix. label Jul 13, 2017
@raimund-schluessler
Copy link
Member Author

I removed the papercut label since this might lead to data loss.

@eibex
Copy link

eibex commented Jun 28, 2020

This still happens on certain occasions. I cannot reproduce it constantly though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants