-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share multiselect overlapped on small screens #23617
Comments
|
I've bisected it but the result doesn't make sense. It points at a commit that doesn't contain any code related to the frontend: 6c1b542 And yet, when I jump back on the previous commit, the autocomplete appears correctly. I tried that repeatedly with various levels of cleanup intensity, and it still happens. Really weird... |
What?! If I check out 6c1b542 and revert the version.php from 21.0.0.1 to 21.0.0.0, the dropdown works again ?! (with full cleanup) |
Trying again without extra apps, just in case, and with production build |
Aha, after resetting the apps folder to what git provides, the error is gone. So it means I had an app in there which CSS caused side effects. Hmmm... And maybe it got auto-enabled on 21.0.0.1 but not 21.0.0.0... Investigating... |
I had the photos app version 1.3.0 (git 63897ad6eb25cce805fe419eac161b97f9db21e9) in my apps folder. For both version.php 21.0.0.0 or 21.0.0.1 the app gets auto-enabled, so it's not an auto-enable bug. Now to find out why a CSS from an app would be different based on version.php... |
I updated the git code from the photos app, now sitting on e4b9123c7488fb2d1d17889f5e0f93d120038fa3 As an app dev I'd expect doing both of these operations to have the same effect ? |
closing as the css problem is gone, but might want a new issue to discuss the compiling bits |
The only scss we have is https://github.com/nextcloud/photos/blob/master/css/icons.scss |
Shoudld be fixed with the |
I can try. However when a preview image is present, there might not be enough room to display it downwards. In general I guess we should perhaps reduce the preview size on smaller screens (small dpi-wise, I have 1080p but with higher dpi so everything looks bigger) |
Of course :p I guess it's fine if we just set it to bottom for now |
okay, I had your branch checked out: nextcloud-libraries/nextcloud-vue#1579 and locally added open direction and it looks better, but there's another unrelated issue which I guess you are working on already: I like that the multiselect adjusts to the remaining height. Next steps:
|
The error disappeared when I switched to nextcloud-vue master.
|
yesterday i've had it with a full screen window with master. |
still visible on stable21 5ec0132 (with no extra files) |
also happening with the 21.0.0RC1 release tarball |
I've tried #24694 (rebased onto master + recompiled), but it doesn't fix this issue. |
a short in the dark: I tried updating nextcloud-vue to 3.5.4 but it also doesn't fix the issue either. |
I had a look deeper into vue-multiselect and it appears that the dropdown is always appended within the same container, not in the body. There is no option to make it use a different containment. |
Seems this is still on a TODO list for the next major vue-multiselect version: shentao/vue-multiselect#618 I see some possible workarounds in that ticket |
okay, back to the old solution: setting the direction to "below". I'll push a PR |
PR here: #25503 |
Steps
Expected result
Can select something.
And if not, at least a way to expand that panel or reduce the preview size to be able to see the panel better.
Actual result
Multiselect dropdown is appearing behind the tabs so cannot see anything
I tried to quickly set z-index on the ".multiselect" element but that didn't help. Might need more advanced CSS engineering or even shifting DOM nodes.
Versions
Observed on git master 872f032
In Nextcloud Talk 20 the dropdown appears correctly above, so this is a regression!
The text was updated successfully, but these errors were encountered: