Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in NC20: no usable file search any more #24029

Closed
andreas-p opened this issue Nov 10, 2020 · 3 comments
Closed

Regression in NC20: no usable file search any more #24029

andreas-p opened this issue Nov 10, 2020 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: search

Comments

@andreas-p
Copy link

Within hours after upgrading to NC20, I got this user feedback:

Searching for files is a lot slower than before the update. The result list is very small, and not als clearly laid out as before. Do we need to live with this or is there another solution?

Universal search has several issues:

  • Performance
    This is covered in issue Files search takes a long time with unified search #23835.

  • Search context
    I've been inquiring some very different long-time computer users, and none of them ever used unified search on Windows or MacOS. In practice, there's always a well-known search context, files, contacts or so, neither of them or me could recall a case of "gimme anything with these letters in it". In addition, the usual file search will be like ls -l <pattern> or find . -name <pattern>, but never find / -name <pattern>.

  • Search result
    When I'm going to the bakery and ask for "pie", I expect to get offers of apple pie and cherry pie, but not books about baking pies, apps for pies, fotos of the Pietà, all videos with Dizzy Gillespie, and certainly not every time I enter the shop.

  • Result representation
    The small window is optically very fancy, but in practice just a peekhole on the data.

Summing up, Universal Search is technologically impressive and good for marketing purposes, but not suitable to fulfill every day's need for file search.

Please consider reviving the "old" file search, with options to search the current directory only, and below only. It should work sufficiently on many files, at least in the current directory. The current approach isn't viable.

@andreas-p andreas-p added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 10, 2020
@Derkades
Copy link

It would be great if, as an alternative to the slow global search, you could just start typing letters and it will filter only the list of items in the current view, like the vscode file tree or nautilus.

@andreas-p
Copy link
Author

@Derkades This is how the file search used to work (and after a delay, it would start a deeper search), which worked fine for the data I'm working with. Right now, I had to disable the file search provider in the code, to prevent unified search from blocking the database server. No way to locate a specific file, in directories with >5k files...

@PVince81
Copy link
Member

PVince81 commented Dec 8, 2020

closing in favor of #23432 which addresses the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: search
Projects
None yet
Development

No branches or pull requests

4 participants