Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile [Meta] #28139

Open
11 of 20 tasks
Pytal opened this issue Jul 23, 2021 · 12 comments
Open
11 of 20 tasks

User Profile [Meta] #28139

Pytal opened this issue Jul 23, 2021 · 12 comments
Assignees
Labels
2. developing Work in progress design Design, UI, UX, etc. enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings feature: users and groups overview

Comments

@Pytal
Copy link
Member

Pytal commented Jul 23, 2021

@jancborchardt
Copy link
Member

jancborchardt commented Aug 24, 2021

So here’s the mockups @nimisha-vijay and I worked on. :)
You can also find them on our Penpot org if you have access.

Personal settings

Has a nice redirect / marketing about the new profile feature, directly showing the hovercard:

Personal settings

Profile

Possible sections:

  • Description / Bio
  • You & this person: Events, mails, Talk messages, shared folders, etc.
  • Photos in a nice grid view
  • Shared resources: Files, folders, file drop, forms, public deck board, etc.
  • (Posts from Social are smth for the dreamworld future ;)

Mobile layout from top to bottom:

  • Avatar
  • Name
  • Role & organization
  • Location & time zone
  • Primary action
  • Other actions
  • Description
  • You & that person
  • Photos
  • Shared resources
  • etc.

Order of actions

  • Book appointment
  • Talk to Jim
  • Email - mailto: link
  • Phone - tel: link
  • Website - visit website
  • Twitter
  • Share a file - opens file picker

Profile

And for yourself it would look like this, with the additional edit buttons: Edit profile, Edit photos, Edit items:
Profile(1)

Empty content

Viewing another person’s profile which is rather empty, we could move the "You & this person" section to the content since otherwise the content will be a bit unbalanced:

Profile-empty-1

Alternatively we could have an empty-content text which might be better since it keeps content in place:
Profile-empty

@tobiasKaminsky
Copy link
Member

Whoever is working on this, please let us talk about proper API for clients.

@Salvador1313

This comment has been minimized.

@Spartachetto

This comment has been minimized.

@Pytal
Copy link
Member Author

Pytal commented Sep 1, 2021

Whoever is working on this, please let us talk about proper API for clients.

For sure! what do you have in mind? Do we have a similar API used by clients that may be used as reference?

@Pytal Pytal mentioned this issue Sep 10, 2021
28 tasks
@Pytal Pytal added the feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) label Sep 10, 2021
@ChristophWurst
Copy link
Member

Makes you approachable and shows Nextcloud ecosystem: Book an appointment, Talk to person

How will we do this? Groupware will take care of the appointments integration. Can we register to render arbitrary content on the profile page like we do on the dashboard? As in, Nextcloud server doesn't have any ties on how Calendar or the appointments feature works, but rather Calendar renders a small component on the profile page that renders the appointments button/widget?

@skjnldsv
Copy link
Member

Makes you approachable and shows Nextcloud ecosystem: Book an appointment, Talk to person

How will we do this? Groupware will take care of the appointments integration. Can we register to render arbitrary content on the profile page like we do on the dashboard? As in, Nextcloud server doesn't have any ties on how Calendar or the appointments feature works, but rather Calendar renders a small component on the profile page that renders the appointments button/widget?

php API
https://github.com/nextcloud/server/blob/bacb4873a1e76ca7cfee8d38b40fdce2474f05cc/lib/public/Profile/IAction.php
https://github.com/nextcloud/server/blob/bacb4873a1e76ca7cfee8d38b40fdce2474f05cc/lib/private/Profile/Actions/TwitterAction.php

@ChristophWurst
Copy link
Member

Thanks. From that code I get that one can only provide links, right? Will we also support running and rendering arbitrary content on the page? Like will the Calendar app be able to load a little widget that, depending on the appointments configurations of the user, renders a button, more than one or none?

@skjnldsv
Copy link
Member

Not yet. Widgets are for another version iirc

@jancborchardt
Copy link
Member

@ChristophWurst design-wise, it is fine to only provide 1 link to the overview page of the booking that is implemented in Calendar.

@ChristophWurst
Copy link
Member

nextcloud/calendar#3541 contains the details for the appoinments integration. From the discussion it shows that we'll need a small enhancement of the current API: it has to be possible to only conditionally render an action. That is, when the profile's user has no public appointment configurations, we won't show an action link. Only if there is a target we will.

But I suppose this will be necessary anyway, give that not every user will have a Twitter account.

@nickvergessen
Copy link
Member

it has to be possible to only conditionally render an action

I discussed this yesterday with Chris. E.g. also the case with Talk as we need to check if the receiving user is allowed to use Talk, not only the visiting user. I think the conclusion was that returning null on the getTargetUrl would prevent the rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design Design, UI, UX, etc. enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings feature: users and groups overview
Projects
Status: 🧭 Planning evaluation / ideas
Development

No branches or pull requests

9 participants