-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Error loading preview on readonly shares #35343
Comments
there's a slight chance that this might be a regression as we touched the preview system in NC 24 to optimize it, not sure if permission checks were affected as well |
Isnt this the reason? |
@szaimen that one is only when download is forbidden. but this ticket here is about read-only, which implies allowed download |
|
Ah I see |
Hello, If hide download, workaround work. |
For information, all request since app (talk; nextcloud) are break for any share (same if download are disabled) |
Same error here, although setup is different:
I marked as bold the components that are the ~same as in @adi-dev's setup. If a folder share is readonly, 404 is returned for previews.
The chances are not that slight 😆 ... I know that everybody's problem is the most important for the person in question, but let me express it with mustering some objectivism: |
Patch are linked for this case no ? If found time, i will test on my preprod for this case |
@come-nc can you have a look ? this issue is specifically for "read-only shares" or where the "upload/write" permission was removed there were mentions of "remove download permission" but this is another separate issue |
I am unable to reproduce this, I tried on master, stable25, and 25.0.1, previews always load fine. |
I see @adi-dev is using https://apps.nextcloud.com/apps/previewgenerator , @Samonitari is that also your case? |
@come-nc , If hide dowload on same share and reload : I don't use your apps and i have disable shareRenammer for test, don't fix On my side, now, any share can be view, for see picture/video ; users need to be download files |
@EricThi This does not look like the same issue, this issue is not with a share link but an internal link according to original description. |
Crap, I made a mistake, and did not read the bug description carefully enough. |
Can you give steps to reproduce your problem then? |
Hi, |
Hello, Now, I get only error on preview side : #37186 I have upgrade to 27.1.4|5 to 29.0.1 directly (keep 1 day on 28.x and no test) |
Bug description
I discovered that my photo album shared as read-only doesn't show previews nor allow to view files. In debug console:
Similar issue: #21740, tried to adjust to
'preview_max_memory' => 512
, but no effect (restarted whole computer).Found that, if I enable editing on the share, the previews are loading as expected.
Steps to reproduce
Expected behavior
Previews shown as in original folder
Installation method
Community Manual installation with Archive
Operating system
No response
PHP engine version
PHP 8.1
Web server
Apache (supported)
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
No response
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
The text was updated successfully, but these errors were encountered: