Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.3.1a/3.1 - Although the page has some headings, these only partially help to structure the page content as the main content of the page, the tables/list view, is not structured by the headings. #36911

Closed
3 tasks done
AndyScherzinger opened this issue Feb 28, 2023 · 8 comments · Fixed by #37174, #37583, nextcloud/photos#1727 or nextcloud-libraries/nextcloud-vue#3957
Assignees
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 28, 2023

It is recommended to remove the current "h1" heading "Nextcloud's homepage" and replace it e.g. with a visually hidden heading "All files" at the beginning of the main landmark. (1)

Fix:

Image

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-be75bbae42-v3-n1

@JuliaKirschenheuter
Copy link
Contributor

Related (same) issue is here: #35626

@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 1, 2023
@AndyScherzinger AndyScherzinger changed the title [BITV] 9.1.3.1a/3.1 - Although the page has some headings, these only partially help to structure the page content as the main content of the page, the tables/list view, is not structured by the headings. It is recommended to remove the current "h1" heading "Nextcloud's homepage" and replace it e.g. with a visually hidden heading "All files" at the beginning of the main landmark. (1) [BITV] 9.1.3.1a/3.1 - Although the page has some headings, these only partially help to structure the page content as the main content of the page, the tables/list view, is not structured by the headings. Mar 9, 2023
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 15, 2023
@JuliaKirschenheuter
Copy link
Contributor

HI @michaelnissenbaum,

could i ask you about this ticket?
This part:

It is recommended to remove the current "h1" heading "Nextcloud's homepage" and replace it e.g. with a visually hidden heading "All files" at the beginning of the main landmark. (1)

is already solved. I would like to ask you about main content of the page. In this ticket is mentioned "the tables/list view, is not structured by the headings" what should we do in that case?

? Should we place something like "Main content" as <h2> for pages with tables/lists view?

On pages without table/lists view there are already <h2> headings taking place:

Screenshot from 2023-03-09 14-02-48

"Appearance and accessibility", "Keyboard shortcuts", "Background" ..and so on are already <h2>.

@michaelnissenbaum
Copy link

Hi @JuliaKirschenheuter,

as I see it, the current implementation at https://try.nextcloud.com/ltd/a11y/ is not entirely correct or at least not what I proposed. For example, my suggestion was to place the h1 heading for "All Files" not in the header element, but in the main landmark, preferably in the DOM right after the navigation. If implemented this way, a screen reader user would have multiple options - to jump directly to a specific landmark/section or to the h1 heading. By jumping directly to the h1 heading, the user would be able to navigate through the main content of the page immediately.

CleanShot 2023-03-31 at 20 37 22@2x

@JuliaKirschenheuter
Copy link
Contributor

Thank you @michaelnissenbaum!

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Apr 5, 2023

@michaelnissenbaum in current implementation it is really hard to move <h1> heading directly under the navigation. It is possible to do it only in apps which are already using Vue. But in older ones it is really hard. I've put <h1> right after the navigation in Photos App. In all other places I've put it as a first node of the <main>.

Screenshot from 2023-04-05 10-33-34
Screenshot from 2023-04-05 10-34-01
Screenshot from 2023-04-05 10-34-22
Screenshot from 2023-04-05 10-42-58

Hope it is ok 🙏

@michaelnissenbaum
Copy link

Hi @JuliaKirschenheuter screenshots you attached to this tickets are looking good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment