Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.1.3.1a/6.1 - All label elements of form elements were mistakenly marked as headings. (1) #36912

Closed
2 tasks done
AndyScherzinger opened this issue Feb 28, 2023 · 5 comments · Fixed by #37211
Closed
2 tasks done

[BITV] 9.1.3.1a/6.1 - All label elements of form elements were mistakenly marked as headings. (1) #36912

AndyScherzinger opened this issue Feb 28, 2023 · 5 comments · Fixed by #37211
Assignees
@JuliaKirschenheuter
Labels
3. to review Waiting for reviews accessibility feature: settings
Milestone
Nextcloud 27

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Feb 28, 2023 •
edited by JuliaKirschenheuter
Loading

Since they are not headings, the heading markup should be removed. Only "Profile picture", "Details", and "Profile visibility" should be implemented as "h3" headings without labels inside.

  • Fix
  • Backport

0daff04b35b3395981d62d5f87436606

ea791921f8d91989b62585d40226bf0f

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-be75bbae42-v6-n1
@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of feature: settings accessibility labels Feb 28, 2023
@JuliaKirschenheuter
Copy link
Contributor

Related (same) issue is here: #35626

@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 14, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Mar 14, 2023
Merged
4 tasks
@JuliaKirschenheuter
Copy link
Contributor

Hi @michaelnissenbaum,

i've changed a structure as you suggested. One open point is: i can't replace "profile picture" because this is a label which belongs to an input field which controls a file upload. I've created additional <h3> with "Your profile information". Is it ok in your eyes? Thank you!

Screenshot from 2023-03-14 14-10-26

@AndyScherzinger AndyScherzinger changed the title [BITV] 9.1.3.1a/6.1 - All label elements of form elements were mistakenly marked as headings. Since they are not headings, the heading markup should be removed. Only "Profile picture", "Details", and "Profile visibility" should be implemented as "h3" headings without labels inside. (1) [BITV] 9.1.3.1a/6.1 - All label elements of form elements were mistakenly marked as headings. (1) Mar 14, 2023
@michaelnissenbaum
Copy link

@JuliaKirschenheuter Looks good to me.

@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 24, 2023
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Mar 24, 2023 •
edited
Loading

Fix:

Backport:

@JuliaKirschenheuter
Copy link
Contributor

backports are not ready: reopening issue

@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 16, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility feature: settings
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging a pull request may close this issue.

Create <h3> headings for profile page. Replace <label> which have… nextcloud/server
3 participants
@AndyScherzinger @JuliaKirschenheuter @michaelnissenbaum