[Bug]: external files app calls same function unnecessarily multiple times #38861
Closed
5 of 8 tasks
Labels
0. Needs triage
Pending check for reproducibility or if it fits our roadmap
26-feedback
bug
feature: external storage
feature: filesystem
performance 🚀
Comments
spamcopilot2
added
0. Needs triage
|
Cc @icewind1991 @nextcloud/server-backend |
|
https://www.php.net/manual/en/function.debug-backtrace.php to enhance your debug log with a stack trace. |
|
Fixed by #38418 ? |
Seems familiar and could be a fix. I will later cherry pick this commit and test this issue again. |
|
@come-nc unfortunately the amount of function calls stays the same. So no fix |
|
What about #38945 ? |
|
It seems the performance gets better, and there are three calls less. So 3 calls to propfind instead of 6. Here are all calls for one file:
After the first call the cache successfully returns the metadata. |
|
Is this Issue done (closeable) or are we still keeping it open to track some specific remaining improvements? |
|
Fixed in #38945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
In an attempt to improve the performance of the external files app, I have added some loggers here and noticed that the same method is called several times for the same file and I wonder what the point is and whether this is intended.
If not, this could be a bug
Steps to reproduce
Expected behavior
A propfind for an (external) file should only be called once.
Either its in the cache or not. If not request the info.
Don´t call the propfind function multiple times and only once receive an answer.
Installation method
Community Manual installation with Archive
Nextcloud Server version
26
Operating system
RHEL/CentOS
PHP engine version
PHP 8.2
Web server
Nginx
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
{ "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "my.site.com", ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/my.site.com", "overwriteprotocol": "https", "dbtype": "pgsql", "version": "26.0.2.1", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "forcessl": true, "forceSSLforSubdomains": true, "theme": "", "maintenance": false, "appstore.experimental.enabled": true, "loglevel": 0, "trashbin_retention_obligation": "auto", "updatechecker": false, "updater.server.url": "https:\/\/updates.nextcloud.com\/updater_server\/", "updater.release.channel": "stable", "htaccess.RewriteBase": "\/", "filelocking.enabled": "true", "memcache.local": "\\OC\\Memcache\\APCu", "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 0, "timeout": 0 }, "mysql.utf8mb4": true, "mail_smtpmode": "smtp", "mail_smtpsecure": "tls", "mail_sendmailmode": "smtp", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauthtype": "LOGIN", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "app_install_overwrite": [ "sharerenamer" ], "default_phone_region": "DE" } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
{"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:55+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"starting dav propfind Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webptime 0.29786000 1686931195","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:55+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webp not in cache. requesting now","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"starting dav propfind Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webptime 0.07201500 1686931197","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"Path known Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webp","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"starting dav propfind Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webptime 0.07237700 1686931197","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"Path known Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webp","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"starting dav propfind Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webptime 0.07260000 1686931197","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"Path known Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webp","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"starting dav propfind Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webptime 0.07281600 1686931197","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"Path known Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webp","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"starting dav propfind Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webptime 0.07302700 1686931197","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}} {"reqId":"XRgc2Xpd40BH5JLrIWOO","level":0,"time":"2023-06-16T15:59:57+00:00","remoteAddr":"","user":"--","app":"dav","method":"","url":"--","message":"Path known Android/Download/DCIM/OpenCamera/IMG_20210911_212900.webp","userAgent":"--","version":"26.0.2.1","data":{"app":"dav"}}Additional info
In the logs you can see the multiple function calls.
There are 3 possible logs:
I added the microtime to be sure that its not the same log just printed multiple times. but you can see different timestamps, so i assume its different function calls.
The text was updated successfully, but these errors were encountered: