Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] occ trashbin:restore should support Groupfolders #39724

Closed
R0Wi opened this issue Aug 5, 2023 · 1 comment · Fixed by #39818
Closed

[feature] occ trashbin:restore should support Groupfolders #39724

R0Wi opened this issue Aug 5, 2023 · 1 comment · Fixed by #39818
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: occ feature: trashbin

Comments

@R0Wi
Copy link
Member

R0Wi commented Aug 5, 2023

Is your feature request related to a problem? Please describe.

Since #28935 we have the possibility to restore deleted files from the trashbin via php occ trashbin:restore. Unfortunately, like also stated in the docs, this command is currently not able to restore files which have been deleted from Groupfolders.

Describe the solution you'd like

It would be great if the command would also be able to restore files which have been deleted from Groupfolders. I could imagine adding a new flag --scope with values user, groupfolders or all, which controls the scope of the restore. For backward compatibility the default should be set to user.

Describe alternatives you've considered

Currently there's no (comfortable) way of restoring a huge amout of deleted files from Groupfolders.

Additional context

One of our customers make use of the NC sync client combined with Groupfolders. In the past some users accidentally deleted huge folders on their local systems and when they got synced, all the files have been gone for everyone. The only possibility to restore these files right now was to use a backup and do a partial restore to the disk, adjusting file permissions, re-reading the files into Groupfolders etc. Restore via UI was not feasible since we're talking about a few thousand files.

Contribution

If you're willing to accept this new feature, I'd be happy to implement it 👍 I just wanted to check your opinion before going into further implementation detail.

@R0Wi R0Wi added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: trashbin feature: occ labels Aug 5, 2023
@solracsf
Copy link
Member

Can't find a reason why a PR shouldn't be welcomed to be reviewed :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: occ feature: trashbin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants