From 1bc2da1c6028d8efaf5bbdfd603a44f96da38bac Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Fri, 7 Oct 2016 17:16:51 +0200 Subject: [PATCH] Improve user list rendering perf by not resorting after every add (#26282) The call to UserList.add() was wrong and was passing "user.lastLogin" as the sort argument which would cause the list to be resorted over and over again for every added item after loading the next page of users. --- settings/js/users/users.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/settings/js/users/users.js b/settings/js/users/users.js index 55c0d84db8cb2..2b0847651ec6c 100644 --- a/settings/js/users/users.js +++ b/settings/js/users/users.js @@ -393,7 +393,7 @@ var UserList = { if(UserList.has(user.name)) { return true; } - var $tr = UserList.add(user, user.lastLogin, false, user.backend); + var $tr = UserList.add(user, false); trs.push($tr); loadedUsers++; });