Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion shows internal user id instead of avatar + display name #10895

Closed
blizzz opened this issue Nov 14, 2023 · 10 comments · Fixed by #11492
Closed

Autocompletion shows internal user id instead of avatar + display name #10895

blizzz opened this issue Nov 14, 2023 · 10 comments · Fixed by #11492

Comments

@blizzz
Copy link
Member

blizzz commented Nov 14, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Use autocompletion to mention a user
  2. hit enter

Expected behaviour

I see a highlighted span containing the avatar and the display name of the mentioned user.

Actual behaviour

I see @userid instead.

No errors in the browser console.

Talk app

Talk app version: 18.0.0-beta2

Browser

Browser name: Firefox

Browser version: 119.0.1

Server configuration

Nextcloud Version: 28.0.0 beta 2

@nickvergessen
Copy link
Member

Also happens for comments:
grafik

But works on the docs:
https://nextcloud-vue-components.netlify.app/#/Components/NcRichContenteditable

So not sure where this goes wrong, but should be in the lib I guess?

@SystemKeeper
Copy link
Contributor

Bildschirmaufnahme.2023-11-14.um.13.08.14.mov

What am I missing? 🤔

@blizzz
Copy link
Member Author

blizzz commented Nov 14, 2023

@SystemKeeper you should not see @joas but 👤 Joas Lastname in the text input box after confirming him.

@SystemKeeper
Copy link
Contributor

@SystemKeeper you should not see @joas but 👤 Joas Lastname in the text input box after confirming him.

🤦 That makes sense, thank you!

@blizzz
Copy link
Member Author

blizzz commented Nov 14, 2023

For the record how it worked in 27:

Screencast_20231114_134030.webm

@Antreesy
Copy link
Contributor

Found it, comes with vue-lib version bump: nextcloud-libraries/nextcloud-vue#4386 (comment)

cc @susnux

@blizzz
Copy link
Member Author

blizzz commented Dec 1, 2023

Still an issue on RC2

@nickvergessen
Copy link
Member

Still an issue on RC2

Yeah, vue library 8.3 was only released after yesterdays Talk release

@nickvergessen
Copy link
Member

Ah, nevermind the linked vue PR is the breaking one, not the fixing one.

Was it actually reported upstream @Antreesy ?

@Antreesy
Copy link
Contributor

Antreesy commented Dec 1, 2023

Link usptream issue: nextcloud-libraries/nextcloud-vue#4901

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Jan 24, 2024
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Jan 24, 2024
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💬 Talk team Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants