Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat in file sidebar todo #2619

Closed
3 of 4 tasks
nickvergessen opened this issue Dec 20, 2019 · 0 comments · Fixed by #2973
Closed
3 of 4 tasks

Chat in file sidebar todo #2619

nickvergessen opened this issue Dec 20, 2019 · 0 comments · Fixed by #2973
Assignees
@nickvergessen
Labels
3. to review bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression
Milestone
v8.0.5

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Dec 20, 2019 •
edited
Loading

  • If the chat tab is opened again after a file is shared the button will still be "Share this file" instead of "Join conversation". It seems that the FileInfo is not properly updated in the server when a file is shared (or unshared). This needs to be further investigated, but it seems to be an issue in the server and not in Talk.
  • The chat tab is shown for folders with a "Conversations are not available for folders" message (not localized). The tab will not be shown once Hide chat tab for folders #2605 is merged, but as it requires a change in server which was not ready for beta 3 that temporary warning is shown for now (to be able to release a Talk version that can be used with beta 3 of server).
  • Chat input is not focused after the chat view is shown.
  • This only adds the chat tab; calls in the sidebar will be added back in a different pull request.
@nickvergessen nickvergessen added 0. Needs triage bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents high regression and removed 0. Needs triage labels Dec 20, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major (18) milestone Dec 20, 2019
@nickvergessen nickvergessen mentioned this issue Dec 20, 2019
Merged
@nickvergessen nickvergessen mentioned this issue Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression
Projects
None yet
Milestone
v8.0.5
Development

Successfully merging a pull request may close this issue.

Focus the chat input in the sidebars nextcloud/spreed
2 participants
@nickvergessen @danxuliu