Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not lint svg files #25

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Do not lint svg files #25

merged 1 commit into from
Jan 4, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 4, 2022

Prevent failures like those

% npm run stylelint          

> viewer@1.8.0 stylelint
> stylelint src


src/assets/menu-sidebar-white.svg
 1:1  ✖  Unknown word  CssSyntaxError

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Jan 4, 2022
@skjnldsv skjnldsv self-assigned this Jan 4, 2022
juliusknorr
juliusknorr approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad there doesn't seem to be an option to just set the allowed globs in the stylelintrc

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Jan 4, 2022

Too bad there doesn't seem to be an option to just set the allowed globs in the stylelintrc

Yep, had the same thought

@skjnldsv skjnldsv merged commit 0cffbfb into master Jan 4, 2022
@skjnldsv skjnldsv deleted the fix/svg-disable branch January 4, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @juliusknorr