Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token unsafe in FreeOTP #1324

Closed
mvvvmd opened this issue Feb 10, 2023 · 2 comments · Fixed by #1482
Closed

Token unsafe in FreeOTP #1324

mvvvmd opened this issue Feb 10, 2023 · 2 comments · Fixed by #1482
Assignees

Comments

@mvvvmd
Copy link

mvvvmd commented Feb 10, 2023

Steps to reproduce

  1. Enable 2fa
  2. Scan the QR code using FreeOTP on Android

Expected behaviour

The account should be added without error

Actual behaviour

Tell us what happens instead

Get the warning "Token is unsafe!"

The token should apparently have at least have at least 128bit and not trigger the error then.

freeotp/freeotp-android#287
https://www.ietf.org/rfc/rfc4226.txt

@ranvis
Copy link

ranvis commented Feb 6, 2024

@nickvergessen
Thank you for the update.
Actually, it is in base 32; 5-bit per char.
I think 160 / 5 = 32 bytes should be enough.

@nickvergessen
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants