Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC20 Login screen cannot load picture #72

Closed
oswaldo-be opened this issue Dec 23, 2020 · 29 comments
Closed

NC20 Login screen cannot load picture #72

oswaldo-be opened this issue Dec 23, 2020 · 29 comments

Comments

@oswaldo-be
Copy link

It says: We couldn't find that picture in big letters

@TartanPaintPot
Copy link

I have a self hosted system, that's showing the same - "We couldn't find that picture"
Tried disabling/enabling to check, even removed and added again - still showing the same message.

All my users love the varying background pictures. Hopefully it's just a case of a referenced directory having moved, and can be repointed etc.

@marius-wieschollek
Copy link
Contributor

This seems to be an issue on the side of unsplash.
The provide an url that should redirect to a random image matching given search terms.
We use the url https://source.unsplash.com/featured/?nature to find images related to nature. This url always returns the not found error.
If another search term is added, the url works again, see: https://source.unsplash.com/featured/?nature,water

@JMoVS
Copy link

JMoVS commented Dec 24, 2020

Hi, if I click on your second link, it also doesn't work (I also face the issue #72 at my instance)

@chillriver
Copy link

Hello together, in my case the second link works. Is there a way to change the term as workaround? I love this feature.

@marneu
Copy link

marneu commented Dec 25, 2020

Suggestion and just an Idea: Make it a bit more comfortable for example include a fixed table array with either date(s|ranges) like Christmas, Silvestre and other world wide valid special days a.s.o. and set a value in the array with corresponding keywords like ?Xmas etc.
Alternate would be to allow a personal setup keyword in user settings - or do both ... would be nice -> feature request?
To answer @chillriver, see nextcloud/apps/unsplash/css/login.css

To spin it further, and make it more flexible Nextcloud.com could provide a public database with special days for any region on this world and the fixed table could become something like

  • region (country code)
  • date (range)
  • keywords
    User setup would be own f.e. architectural or the default is regional

@Ivar418
Copy link

Ivar418 commented Dec 26, 2020

i also have the same issue for my self hosted nc server on my raspberry pi. it shows the no image found. also on the statusbar if enabled

@crewdk
Copy link

crewdk commented Dec 26, 2020

If another search term is added, the url works again, see: https://source.unsplash.com/featured/?nature,water

Thnx, this works for me.

For all: you could just edit search terms in files:

/apps/unsplash/css/header.css
/apps/unsplash/css/login.css

@meepmeep
Copy link

It looks like the "nature" category doesn't work anymore.

From the unsplash website : https://source.unsplash.com

So i modify files from #72 (comment) to set :
https://source.unsplash.com/featured/?wallpapers

(other category like "architecture" doesn't work either).
So the issue is on unsplash side ...

@TartanPaintPot
Copy link

I have a self hosted system, that's showing the same - "We couldn't find that picture"
Tried disabling/enabling to check, even removed and added again - still showing the same message.

All my users love the varying background pictures. Hopefully it's just a case of a referenced directory having moved, and can be repointed etc.

OK, all fixed after I edited the 2 files in the following location: /var/snap/nextcloud/current/nextcloud/extra-apps/unsplash/css/header.css & login.css

to have the following URL https://source.unsplash.com/featured/?nature,water and all working again.

Hope this helps anyone else out - if you've installed NextCloud with snap, that is....

@chillriver
Copy link

If another search term is added, the url works again, see: https://source.unsplash.com/featured/?nature,water

Thnx, this works for me.

For all: you could just edit search terms in files:

/apps/unsplash/css/header.css
/apps/unsplash/css/login.css

This workaround works well for me. Thanks.

@thilojaeggi
Copy link

@Ivar418
Copy link

Ivar418 commented Dec 28, 2020

Using https://source.unsplash.com/featured/?nature,nature works too.

That makes so little sense that it does. Funny😂

@marneu
Copy link

marneu commented Dec 28, 2020

@meepmeep: https://source.unsplash.com/featured/?architectural works too. (architecture!=architectural). You could also try ?architectural,historical or ?architectural,modern
But isn't this the time for ?silvester aka ?newyear 😂

@Superyorch
Copy link

Superyorch commented Dec 29, 2020

I have modified both files (header and login) and added water at the end, nature again, architectural and still in all cases receiving the same error.
Update: Here is the tracing of the request using the Network analyzer within Firefox
`GEThttps://source.unsplash.com/featured/?nature,water
[HTTP/1.1 302 Found 125ms]

GET
https://source.unsplash.com/featured/?nature,water=
Status302
Found
VersionHTTP/1.1
Transferred41.54 KB (40.90 KB size)
Referrer Policyno-referrer

Cache-Control
	no-cache
Connection
	keep-alive
Content-Type
	text/html; charset=utf-8
Date
	Tue, 29 Dec 2020 18:19:44 GMT
Location
	https://images.unsplash.com/source-404?fit=crop&fm=jpg&h=800&q=60&w=1200
Referrer-Policy
	strict-origin-when-cross-origin
Server
	Cowboy
Strict-Transport-Security
	max-age=31536000; includeSubDomains
Transfer-Encoding
	chunked
Vary
	Origin
Via
	1.1 vegur
X-Content-Type-Options
	nosniff
X-Download-Options
	noopen
X-Frame-Options
	SAMEORIGIN
X-Permitted-Cross-Domain-Policies
	none
X-Request-Id
	e16aa051-984a-4f89-
X-Runtime
	0.025535
X-Xss-Protection
	1; mode=block
	
Accept
	image/webp,*/*
Accept-Encoding
	gzip, deflate, br
Accept-Language
	en-US,en;q=0.7,es-MX;q=0.3
Cache-Control
	no-cache
Connection
	keep-alive
DNT
	1
Host
	source.unsplash.com
Pragma
	no-cache
Sec-GPC
	1
User-Agent
	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:84.0) Gecko/20100101 Firefox/84.0`

@newhinton
Copy link
Contributor

I will fix that, but it will probably take me some time since i am currently fixing my own nextcloud. i hope that i can get an update out around new year's eve, with the improvement suggested by @marius-wieschollek

@Superyorch
Copy link

thank you! After fiddling around with other tokens like: water, tech, wallpapers, architecture, etc they all seem to work perfectly and the only broken one is nature. Hope that helps narrow it down to the culprit. Happy new year!

@Valdnet
Copy link
Contributor

Valdnet commented Dec 30, 2020

I propose to add the link change function from the Administrator Panel 😁.

marius-wieschollek added a commit to marius-wieschollek/unsplash that referenced this issue Dec 31, 2020
marius-wieschollek added a commit to marius-wieschollek/unsplash that referenced this issue Dec 31, 2020
Signed-off-by: Marius David Wieschollek <git.public@mdns.eu>
newhinton added a commit that referenced this issue Dec 31, 2020
[#72] Add workaround for unsplash api issue
@Valdnet
Copy link
Contributor

Valdnet commented Jan 3, 2021

@newhinton The solution in PR #76 does not fix the bug. After a few views of the NC page, the message "We couldn't find that photo" is displayed again.

@wilfreddijksman
Copy link

The url https://source.unsplash.com/featured/nature works for me (without the question mark).

@Valdnet
Copy link
Contributor

Valdnet commented Jan 3, 2021

@wilfreddijksman The link without a question mark displays images from different groups (not only from nature).

@marius-wieschollek
Copy link
Contributor

I can confirm that my PR does no longer fix the issue. Also https://source.unsplash.com/featured/?nature,water does return images that clearly don't match (like fireworks)

The api seems to be really broken right now

@Corum92
Copy link

Corum92 commented Jan 5, 2021

Thanks for fixing this (if done actively). Works again on my end with lovely pictures from oranges, nature et al. Cheers!

@newhinton
Copy link
Contributor

We didnt really do anything, but it seems that the issue was not on our end. For the future i will have to update the app to easily switch categories, so that this will not happen again

@tom-ch1
Copy link

tom-ch1 commented Jan 6, 2021

https://source.unsplash.com/1920x1080/?nature,, seem to work (...right now, for me... ;-) )

@Corum92
Copy link

Corum92 commented Jan 6, 2021

Thanks for fixing this (if done actively). Works again on my end with lovely pictures from oranges, nature et al. Cheers!

And gone again. Error message is back on ... Maybe it is a slack joint @unsplash ;-)

@armaccloud
Copy link

armaccloud commented Jan 9, 2021

I had contact with Unsplash Support; apparently the source.unsplash.com URL is not supported anymore.
I think this requires a structural change in the nextcloud unsplash app.

image

@newhinton
Copy link
Contributor

that is good to know! thanks for sharing this with us.
I already have some baseline work for other imageprovider, so i'll have to finish those rather soon :D

@newhinton
Copy link
Contributor

I will close this issue since it seems resolved. The fact that the original unsplash api is unsupported will be handled in a different pr when it comes to that.

@froman753
Copy link

I'm currently running into this issue. Has there been any progress on migrating to the new API in the last 14 months?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests