Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mbstring-extensions as applicable #33

Open
joho1968 opened this issue Mar 22, 2023 · 1 comment
Open

Use mbstring-extensions as applicable #33

joho1968 opened this issue Mar 22, 2023 · 1 comment

Comments

@joho1968
Copy link

I've just been browsing the code a bit to see if I can contribute, but one thing that I noticed is the use of some non-mbstring string functions.

Since Nextcloud requires the mbstring functions to be present in PHP, I think it'd be a good idea if the welcome app made use of them where applicable.

https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html

(see "Prerequisites for manual installation")

Just my two cents.

@kyteinsky
Copy link
Contributor

The code with non-mbstring functions has been overwritten and since the new functions only handle URIs, I doubt there is any need for mbstrings here. (b9683f5#diff-04ace24b494c1cf87cb15970508f767e982403f9001ea2f5faa80e9f4247f55fR140)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants