Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list (maybe run?) doesn't respect CARGO_TARGET_{TRIPLE}_RUNNER #57

Closed
Jake-Shadle opened this issue Feb 17, 2022 · 5 comments · Fixed by #61
Closed

list (maybe run?) doesn't respect CARGO_TARGET_{TRIPLE}_RUNNER #57

Jake-Shadle opened this issue Feb 17, 2022 · 5 comments · Fixed by #61
Labels
bug Something isn't working

Comments

@Jake-Shadle
Copy link
Contributor

We build and test Windows binaries from Linux, and use CARGO_TARGET_{TRIPLE}_RUNNER to specify (in our case) wine so that we can test the binaries, however nextest doesn't seem to read this configuration and attempts to directly execute the test binaries when performing the initial test list before running the tests.

I can add support for this tomorrow in a PR, just thought I would file this issue for visibility. Great work on this btw!

@sunshowers sunshowers added the bug Something isn't working label Feb 17, 2022
@sunshowers
Copy link
Member

Thanks for the kind words! Yes, nextest doesn't support that option today. This is a bug and a and a PR would be really welcome!

@sunshowers
Copy link
Member

To determine platform etc support, you'll probably want to just use target-spec, which depends on your own cfg-expr library!

@sunshowers
Copy link
Member

@Jake-Shadle I had a look at cargo's config and it feels like it'll be really hard to emulate all of it correctly. What do you think of adding this to nextest.toml instead?

@sunshowers
Copy link
Member

@Jake-Shadle this is now released as 0.9.6 -- could you confirm that https://nexte.st/book/target-runners.html makes sense to you? Thanks!

@Jake-Shadle
Copy link
Contributor Author

Thanks for the quick release! Yes, the docs make sense to me, I think the biggest thing is that people who are already using one of those methods for setting a target runner will be able to drop in nextest with no problems. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants