-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postfixing +
in nextflow.version.matches()
is not working properly
#5016
Comments
The root cause seems to be when the major version is greater but the minor version isn't. I'm surprised this bug wasn't noticed before! Looking into a patch |
@pditommaso now I'm confused about the meaning of '1.2' | '1.2.+' | true
'1.3' | '1.2.+' | false // ???
'2.3.1b' | '2.3.+' | true
'2.4' | '2.3.+' | false // ???
'1.2' | '1.+' | true Apparently the plus works like |
|
Doc mentions
Shouldn't |
|
Then this behavior needs to be documented. @HarryHung I think the |
Sure can do, but if this is the intended behaviour, I would suggest updating the docuementation:
Because it seems both the wordings and the example do not align well with its intended behaviour? Thanks! |
Bug report
Expected behavior and actual behavior
The following two code blocks should work the same (i.e. it should not go inside of the
if
block) if the Nextflow executable is at 23.10 or newer.Version 1
Version 2
In
23.xx
, both versions work fine for me. But after I have upgraded the executable to24.04.1
, version 1 no longer works properly and go into theif
block.Steps to reproduce the problem
With the following content in
test.nf
By running
./nextflow run test.nf
with...23.10.1
executable: PrintDone
24.04.1
executable: Print the error messageProgram output
As mentioned above
Environment
24.04.1
19.0.2
The text was updated successfully, but these errors were encountered: