Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/DEV: test bash tests/builds/runner.sh not mentioned in dev docs #1020

Closed
corneliusroemer opened this issue Aug 10, 2022 · 2 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@corneliusroemer
Copy link
Member

There seems to be a test that is only run in CI but missing from the dev documentation.

It'd be great if the person who added the line to the CI config - run: bash tests/builds/runner.sh could explain how to do this locally and what is being tested. I think it was @victorlin.

Thanks!

I think it was in commit 092879b

Example where this test fails and I don't immediately understand why: https://github.com/nextstrain/augur/runs/7766923240?check_suite_focus=true#step:11:258

@tsibley
Copy link
Member

tsibley commented Aug 22, 2022

tests/builds/runner.sh was added in 2710dbc by @jameshadfield to the Travis CI config.

It was first mentioned in DEV_DOCS.md in e17be15 by @huddlej and then subsequently reworked in 0878320 and 070c6a7.

Its invocation was migrated from Travis CI → GitHub Actions in 092879b by @victorlin, as you noted.

It was (incidentally?) removed from DEV_DOCS.md in f1ae13e by @victorlin as part of other changes.

@victorlin victorlin moved this from New to Prioritized in Nextstrain planning (archived) Aug 23, 2022
@victorlin
Copy link
Member

Apologies for not responding earlier when this came up. tests/builds/runner.sh was used to run test workflows using Snakemake. Those have since been removed in #1302, including the script itself.

The DEV_DOCS mention was removed in f1ae13e because the step "Run devel/test" included invocation of that script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Status: Prioritized
Development

No branches or pull requests

3 participants