Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Nextstrain fails to render correctly in the latest version of Firefox on Windows #1005

Closed
heliosfa opened this issue Mar 27, 2020 · 12 comments
Labels
bug Something isn't working please take this issue

Comments

@heliosfa
Copy link

Current Behavior
When loading the Novel Coronavirus build at https://nextstrain.org/ncov in the latest version of Firefox (and Waterfox Classic) on Windows, many of the branches of the phylogeny tree are not rendered as per this screenshot:
image

This issue has only started to occur in the last day (26/03/2020) and the tree used to render correctly on this platform/browser combination.

Expected behavior
I would expect the tree to render correctly as it does in Chrome:
image

How to reproduce
Steps to reproduce the current behavior:

  1. Open https://nextstrain.org/ncov in the latest version of Firefox or Waterfox on Windows
  2. See error

Your environment: if browsing Nextstrain online

  • Operating system: Windows 10 Enterprise 1809, Windows 10 Education N 1909, Windows 8.1 Enterprise
  • Browser: Firefox 74.0 (64-bit), Waterfox Classic 2020.03.1 (64-bit)

Additional context
This has been tested on multiple computers (including a disposable, non-persistent VM with the portable version of Firefox 74) with all add-ons disabled and with clean profiles.

Renders correctly in Firefox 74 and Waterfox Classic 2020.03.1 (64-Bit) on MacOS 10.14.6

@heliosfa heliosfa changed the title [BUG] [BUG] NExtstrain fails to render correctly in the latest version of Firefox on Windows Mar 27, 2020
@heliosfa heliosfa changed the title [BUG] NExtstrain fails to render correctly in the latest version of Firefox on Windows [BUG] Nextstrain fails to render correctly in the latest version of Firefox on Windows Mar 27, 2020
@jameshadfield jameshadfield transferred this issue from nextstrain/ncov Mar 27, 2020
@jameshadfield
Copy link
Member

This bug was introduced via the SVG gradients applied in PR #947. Can confirm it works on Firefox 74 on MacOS, which implies it is OS specific.

@heliosfa
Copy link
Author

@jameshadfield thanks for moving this to the correct repo and I'm glad it was easy to identify the cause - hopefully it's not too nasty to fix!

@jameshadfield
Copy link
Member

I use MacOS (and we don't have any OS-specific testing) so thanks for raising this issue as we wouldn't have otherwise known about it! Hopefully someone who uses Windows can help with a fix (@ivan-aksamentov perhaps?)

@jameshadfield jameshadfield added the bug Something isn't working label Mar 27, 2020
@ivan-aksamentov
Copy link
Member

@jameshadfield Sorry James, cannot help at this time. We are swamped with a project of ours.

But it's not a rocket science: I just run a Windows 7 guest in Virtualbox on my Ubuntu. Then run a browser in question and navigate to http://10.2.2.0:4000 (or 5000). This is the default address which maps to the host machine's localhost (on Ubuntu in my case), where auspice or nextstrain prod server runs. That's it. Hope you can nail it! 🤞

@emmahodcroft
Copy link
Member

Can confirm this is also true for me, on Windows 10, running an older Firefoxx 72.0.2 (64-bit)

@emmahodcroft
Copy link
Member

For me, some of the gradients render:
image

@lmoncla
Copy link
Contributor

lmoncla commented Mar 27, 2020

This happened to me here,
Screen Shot 2020-03-27 at 4 06 19 PM
using Mac OSX 10.12.6, using Brave browser 1.4.96.

@gj262
Copy link

gj262 commented Mar 28, 2020

@jameshadfield ping me if you need help testing a fix i.e. I have a saucelabs.com account and can preview any changes you make. (I'd offer to help fix but my SVG knowledge is rusty.)

@cpsandbox
Copy link
Contributor

Yes. This works on Linux/chrome/Firefox as well. @imoncla @heliosfa Is this on the first render or after changing the color by?

@heliosfa
Copy link
Author

@cpsandbox this is on first render and after changing the color by.

I can get the full tree if I change the "color by" to something like "Exposure History" that is more monochrome
image

Playing about with the colour by options, some of the options with gradients render some of the branches some of the time. e.g. on this one coloured by Submission Date the yellow-grey gradients render, but the orange-grey one to Iceland/220/2020 does not:

image

Which branches render is not consistent by zoom level, e.g. zooming into the cluster of new Welsh cases:
image

image

image

image

Some of the branches render momentarily during a zoom onto a more specific part of the tree before disappearing.

@lmoncla
Copy link
Contributor

lmoncla commented Mar 28, 2020

@cpsandbox on initial render

@jameshadfield
Copy link
Member

Closing this as we've reverted back to non-gradient branches. Thanks for all the detailed reports here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working please take this issue
Projects
None yet
Development

No branches or pull requests

7 participants