Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates Before Present are -undefined #1294

Closed
ktmeaton opened this issue Feb 26, 2021 · 2 comments · Fixed by #1297
Closed

Dates Before Present are -undefined #1294

ktmeaton opened this issue Feb 26, 2021 · 2 comments · Fixed by #1297
Labels
bug Something isn't working

Comments

@ktmeaton
Copy link

Current Behavior
When "Branch Length" TIME is selected, dates before present appear as "-undefined" on the axis labels. Despite the inferred dates and confidence intervals displaying correctly.

image

Expected behavior
I would like axis labels for dates before present to appear as "-2000 ... -1000..." not -undefined. This was how it worked in a previous version of auspice, but I'm not sure where the changed occurred.

How to reproduce

  1. Remote: https://nextstrain.org/community/ktmeaton/plague-phylogeography/clock-model?ci&m=num_date
  2. Local:
    • Unzip the following archive, which contains the json ready to be visualized with auspice.
      clock_model_auspice.zip
    • Start the auspice server. For local visualization:
    HOST="localhost" auspice view --datasetDir .

Your environment: if browsing Nextstrain online

  • Operating system: Windows 10
  • Browser: Google Chrome and Microsoft Edge

Your environment: if running Nextstrain locally

  • Operating system: WSL2 Ubuntu 20.04
  • Browser: Google Chrome and Microsoft Edge
  • Version: auspice 2.22.0 and auspice 2.23.0)

Thank you!!

@ktmeaton ktmeaton added the bug Something isn't working label Feb 26, 2021
@jameshadfield
Copy link
Member

jameshadfield commented Mar 1, 2021

Thanks for the detailed bug report & for including a dataset to reproduce ⭐

PR #1297 fixes this and should be in an auspice release this week. (Please feel free to test that if you're comfortable installing auspice from source.)

@ktmeaton
Copy link
Author

ktmeaton commented Mar 4, 2021

Thank you for looking into this! I've made a few attempts to install auspice from source (off master). The build succeeds but I haven't been able to run the local server successfully. I'm sure this is entirely because of my inexperience with nodejs :) I will just wait for the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants