Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar] Fix flashing when image is already cached #3437

Closed
daveycodez opened this issue Jul 9, 2024 · 12 comments · Fixed by #3987
Closed

[Avatar] Fix flashing when image is already cached #3437

daveycodez opened this issue Jul 9, 2024 · 12 comments · Fixed by #3987
Labels
📦 Scope : Components Related to the components ✨ Type: Enhancement New enhancement on existing codebase

Comments

@daveycodez
Copy link

NextUI Version

2.4.2

Describe the bug

Avatars flicker and animate when they should be rendered instantly when cached, Radix shows a fix here ->

radix-ui/primitives#3008

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

Using Avatar should render immediately if the image is cached with no loading animation or flickerAvatars flicker and animate when they should be rendered instantly when cached, Radix shows a fix here ->

radix-ui/primitives#3008

Expected behavior

Using Avatar should render immediately if the image is cached with no loading animation or flickerAvatars flicker and animate when they should be rendered instantly when cached, Radix shows a fix here ->

radix-ui/primitives#3008

Screenshots or Videos

No response

Operating System Version

macOS

Browser

Chrome

Copy link

linear bot commented Jul 9, 2024

@uigywnkiub
Copy link

+, even with Image from next as Avatar or User props...

@awesome-pro
Copy link
Contributor

@wingkwong I am working on it.

@rkkautsar
Copy link
Contributor

@abhinandan-verma hi very sorry I have already worked on this since it's similar to my MR in radix. I didn't see your comment here when I worked on it. I have put up an MR here if you want to review: #3444. Let me know if it's acceptable or you can close it if you already has something else. Thanks

@awesome-pro
Copy link
Contributor

@rkkautsar Thanks for your MR. I was working on it, but Your MR seems more effective.
Kindly update the PR summary , description to make it more understandable.

@ameytessact
Copy link

is there any temporary fix until the PR is merged? I am facing the same issue with NextImage passed as ImgComponent.

@daveycodez
Copy link
Author

@abhinandan-verma Has this made it into 2.4.6 by any chance?

@uigywnkiub
Copy link

Still bug in 2.4.5 and 2.4.6

@daveycodez
Copy link
Author

daveycodez commented Aug 4, 2024

Should we just go ahead and use Radix for this component? Any ETA?

@wingkwong wingkwong added ✨ Type: Enhancement New enhancement on existing codebase 📦 Scope : Components Related to the components labels Aug 6, 2024
@daveycodez
Copy link
Author

It's October so I just published a fix while we wait

https://github.com/daveyplate/nextui-fixed-avatar

npm install @daveyplate/nextui-fixed-avatar

@uigywnkiub
Copy link

It's October so I just published a fix while we wait

https://github.com/daveyplate/nextui-fixed-avatar

npm install @daveyplate/nextui-fixed-avatar

Wow nice aha

@daveycodez
Copy link
Author

daveycodez commented Dec 6, 2024

Hey @jrgarciadev this is still broken in 2.6.2, it seems to only work when you add disableAnimation prop but this disables the fade in for uncached images. Although even with disableAnimation there is a very quick flicker still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Scope : Components Related to the components ✨ Type: Enhancement New enhancement on existing codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants