Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give conda environments a name #4234

Closed
edmundmiller opened this issue Oct 25, 2023 · 2 comments · Fixed by #4327
Closed

Give conda environments a name #4234

edmundmiller opened this issue Oct 25, 2023 · 2 comments · Fixed by #4327

Comments

@edmundmiller
Copy link
Contributor

          > Not seen [this error](https://github.com/nf-core/modules/actions/runs/6635360127/job/18030179941?pr=4225) before:

java.nio.channels.OverlappingFileLockException
is that related to the conda environment change?

I see this error appears when running tests for subworkflows. Could be that we need to add a name to environment.yml? If two modules in a subworkflow have exactly the same environment.yml I suspect the environment names may clash

Originally posted by @mirpedrol in #4225 (comment)

@edmundmiller
Copy link
Contributor Author

edmundmiller commented Oct 25, 2023

We need to decide how we're going to name them.

There's a few with a name already:

name: nf-core-vep-108.2
name: nf-core-snpeff-5.1

However, I'd vote we just keep it in line with the name field in the meta.yml. Easy to lint, no /'s or extra nf-core separators.

@mashehu
Copy link
Contributor

mashehu commented Oct 25, 2023

Same as meta.yml sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants