Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong assay and study paths in RO-Crate export #473

Open
floWetzels opened this issue Nov 7, 2024 · 0 comments
Open

[BUG] Wrong assay and study paths in RO-Crate export #473

floWetzels opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@floWetzels
Copy link
Collaborator

The identifiers of assays and studies in the json object produced by the RO-Crate export sometimes contain invalid paths. In particular, they sometimes start with a # symbol. This is then not valid RO-Crate.

Furthermore, the RO-Crate specification states that paths SHOULD end in a / symbol, which we should probably also adapt.

To Reproduce
Go to the Metabolights338_ARC from the datahub. Export the RO-Crate in the same way the CI does (only tested with CI output).

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Nov 7, 2024
@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Nov 18, 2024
@HLWeil HLWeil moved this to In discussion in ARCStack Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: In discussion
Development

No branches or pull requests

2 participants