catch invalid roof values in load_schedules()
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
perfect ty! |
Merged
mrcaseb
added a commit
that referenced
this pull request
Oct 4, 2023
In #218 I added a set of valid roof type values. I can't remember why I put "indoors" in there but it is actually invalid. This PR removes that value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nflfastR and nfl4th use the "roof" variable in several models
These models expect one of c("indoors", "closed", "outdoors", "open", "retractable") or NA
We ran into problems where roof was empty or something else several times
So we catch these cases here and change invalid data to NA