Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required features when developing new PFR workflows #37

Open
3 tasks
mrcaseb opened this issue Sep 16, 2024 · 5 comments
Open
3 tasks

Required features when developing new PFR workflows #37

mrcaseb opened this issue Sep 16, 2024 · 5 comments

Comments

@mrcaseb
Copy link
Member

mrcaseb commented Sep 16, 2024

  • Automatically re-scrape current week on Wednesday or Thursday
  • Make it as easy as possible to re-scrape a game/week/season. Currently we have to download the released games csv, modify it and reupload it. A csv could be fine but then it should live in git and not in a release. Also the list should be sorted by newest to oldest.
  • Fix variable naming or selection related to [BUG] 2024 data - some games missing, some mis-mapped columns #36 (comment)
  • Spread datatypes across multiple runners? This could avoid the variable naming and selection problem above

Unrelated to the actual workflow but the repo needs to be cleaned up. There's a lot of code that isn't in use.

@tanho63
Copy link
Member

tanho63 commented Sep 16, 2024

Make it as easy as possible to re-scrape a game/week/season. Currently we have to download the released games csv, modify it and reupload it. A csv could be fine but then it should live in git and not in a release. Also the list should be sorted by newest to oldest.

We should really be able to pass in a game ID via gha workflow input rather than that dance we do right now, I don't think we knew how to do that when we wrote PFR stuff

@tanho63
Copy link
Member

tanho63 commented Sep 16, 2024

Spread datatypes across multiple runners? This could avoid the variable naming and selection problem above

SEB WE DON'T NEED TO DO MULTIPLE RUNNERS FOR EVERYTHING,,,,,,,,,,,,,,,,,,,,,,,,,,
actually it could be interesting to do one runner per game if you wanted to

@mrcaseb
Copy link
Member Author

mrcaseb commented Sep 16, 2024

Spread datatypes across multiple runners? This could avoid the variable naming and selection problem above

SEB WE DON'T NEED TO DO MULTIPLE RUNNERS FOR EVERYTHING,,,,,,,,,,,,,,,,,,,,,,,,,, actually it could be interesting to do one runner per game if you wanted to

I am actually not sure about that anyways. I wonder if concurrent calls to undercover could cause problems

@tanho63
Copy link
Member

tanho63 commented Sep 16, 2024

SEB WE DON'T NEED TO DO MULTIPLE RUNNERS FOR EVERYTHING,,,,,,,,,,,,,,,,,,,,,,,,,, actually it could be interesting to do one runner per game if you wanted to

I am actually not sure about that anyways. I wonder if concurrent calls to undercover could cause problems

Good question, undercover seems to be limited on our current plan to just 1 concurrent call so we probably should stick with what we have for now

@mrcaseb
Copy link
Member Author

mrcaseb commented Sep 16, 2024

So I guess the most important thing is the ability to trigger rebuild of a week and specific game through workflow dispatch as well as automatic rescrape of current weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants