fix: metrics #1051
fix: metrics #1051
Conversation
Deploying with
|
| Latest commit: |
cf49f10
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a9eae64a.nft-storage-1at.pages.dev |
| @@ -14,6 +14,7 @@ export async function dbTypesCmd() { | |||
|
|
|||
| try { | |||
| await dbSqlCmd({ cargo: true, testing: true }) | |||
| await delay(2000) | |||
There was a problem hiding this comment.
Is there a reason for this?
There was a problem hiding this comment.
Yes I was getting a socket hangup error. I think because the new postgrest version restarts itself when changes are made. It just needs a second or two to come back.
packages/api/src/routes/metrics.js
Outdated
| ) | ||
| return { totals: Object.assign({}, ...totals) } | ||
| } | ||
| const UPLOAD_TYPES = ['Car', 'Blob', 'Multipart', 'Remote', 'Nft'] |
There was a problem hiding this comment.
nit: it would be great to have these in a single place. Currently, we have them at list here and in the cron code. This might be error prone in the case of a new PinService, or type of upload as we can forget to update the other side.
There was a problem hiding this comment.
We already do this in the cron package:
import { DBClient } from '../../../api/src/utils/db-client.js'So I think should be ok to import them...
| await pg.query(UPDATE_METRIC, [metric.name, metric.value]) | ||
| } | ||
|
|
||
| if (error) throw error |
There was a problem hiding this comment.
Good call that we update what we can and only error in the end. We still need to create an issue to integrate these errors with an alert system.
There was a problem hiding this comment.
I saw this in the pins job
nft.storage/.github/workflows/cron-pins.yml
Lines 35 to 37 in 20ee0b6
Is that what we want @hugomrdias?
There was a problem hiding this comment.
Oh yes, I think that's it. Not sure if we need any config in the expected opsgenie heartbeat timings
Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
This PR:
metric/metricsendpoint to query themetrictable for the latest value