feat: track content length histogram #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/track-content-length-histogram
branch
from
8d6c61c to
30ccb60
Compare
Deploying with
|
| Latest commit: |
9ed90c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47f39b7e.nft-storage-1at.pages.dev |
vasco-santos
force-pushed
the
feat/track-content-length-histogram
branch
from
30ccb60 to
fffca73
Compare
vasco-santos
force-pushed
the
feat/track-content-length-histogram
branch
2 times, most recently
from
fc55049 to
e6ce43d
Compare
vasco-santos
force-pushed
the
feat/track-content-length-histogram
branch
from
e6ce43d to
fb5065f
Compare
alanshaw
requested changes
Feb 3, 2022
Comment on lines
50
to
55
| this.totalContentLengthBytes = | ||
| (await this.state.storage.get(TOTAL_CONTENT_LENGTH_BYTES_ID)) || 0 | ||
| // Total cached content length responses | ||
| this.totalCachedContentLengthBytes = | ||
| (await this.state.storage.get(TOTAL_CACHED_CONTENT_LENGTH_BYTES_ID)) || | ||
| 0 |
There was a problem hiding this comment.
These need to be BigInt. Apparently DO storage supports every type supported by the Structured Clone algorithm which includes BigInt thankfully.
https://developers.cloudflare.com/workers/runtime-apis/durable-objects#transactional-storage-api
|
|
||
| // We will count occurences per bucket where content size is less or equal than bucket value | ||
| export const contentLengthHistogram = [ | ||
| 0.5, 1, 2, 5, 25, 50, 100, 500, 1000, 5000, 10000, 15000, 20000, 30000, 32000, |
There was a problem hiding this comment.
I think these need to be converted to bytes...?
| @@ -70,6 +77,26 @@ test('Gets Metrics content', async (t) => { | |||
| const response = await mf.dispatchFetch('http://localhost:8787/metrics') | |||
| const metricsResponse = await response.text() | |||
|
|
|||
| // content length of responses is 23 | |||
There was a problem hiding this comment.
What do you mean below? Want to get the metrics before the requests and see if content length is zero?
There was a problem hiding this comment.
added that case
alanshaw
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds content length histogram tracking, as well as content length of cached responses, so that we can compare the amount of data we had cached
Closes #1181