Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add durable object types #1212

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

vasco-santos
Copy link
Contributor

Adds Cloudflare Durable object types inline and the @cloudflare/workers-types dev dependency. The Durable objects types are not exported from @cloudflare/workers-types

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 2, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8d3dc3
Status: ✅  Deploy successful!
Preview URL: https://afb8ff4f.nft-storage-1at.pages.dev

View logs

@vasco-santos vasco-santos requested a review from alanshaw February 2, 2022 09:55
Copy link
Contributor

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably open an issue upstream about.

@@ -28,6 +28,7 @@
"toucan-js": "^2.5.0"
},
"devDependencies": {
"@cloudflare/workers-types": "^3.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this as a dep? Not being used...right?

@vasco-santos vasco-santos force-pushed the fix/add-durable-objects-types branch from fafcad3 to b8d3dc3 Compare February 22, 2022 08:50
@vasco-santos vasco-santos merged commit ffc9934 into main Feb 22, 2022
@vasco-santos vasco-santos deleted the fix/add-durable-objects-types branch February 22, 2022 09:02
dashcraft pushed a commit that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants