feat: track cached response times #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8884012
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://85044de8.nft-storage-1at.pages.dev |
vasco-santos
force-pushed
the
feat/track-cached-response-times
branch
2 times, most recently
from
5739e8d to
8c0f3f9
Compare
vasco-santos
commented
Feb 3, 2022
| /** @type {ContentLengthStats} */ | ||
| data = await request.json() | ||
| await this._updateWinnerMetrics(data) | ||
| await this._updatedCacheMetrics(data) |
There was a problem hiding this comment.
😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱
vasco-santos
commented
Feb 3, 2022
| return env.ipfsGateways | ||
| .map( | ||
| (gw) => | ||
| `nftgateway_requests_per_time_total{gateway="${gw}",le="${t}",env="${env.ENV}"} ${metricsCollected.ipfsGateways[gw].responseTimeHistogram[t]}` | ||
| `nftgateway_requests_per_time_total{gateway="${gw}",le="${msToS( |
There was a problem hiding this comment.
also made the le with seconds as we use seconds everywhere per Prometheus best practises
vasco-santos
force-pushed
the
feat/track-cached-response-times
branch
from
7b0c194 to
f5f2c76
Compare
vasco-santos
force-pushed
the
feat/track-cached-response-times
branch
from
f5f2c76 to
1fbca4f
Compare
alanshaw
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: