Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gateway track redirect counts #1237

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

vasco-santos
Copy link
Contributor

Adds a counter to track redirects when rate limited to have a metric and better view if all fail in any situation.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 4, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: afcbd01
Status: ✅  Deploy successful!
Preview URL: https://5f5d3d08.nft-storage-1at.pages.dev

View logs

@vasco-santos vasco-santos force-pushed the feat/gateway-track-redirect-counts branch from 827798e to c2de560 Compare February 4, 2022 12:08
@vasco-santos vasco-santos requested a review from alanshaw February 4, 2022 12:14
@vasco-santos vasco-santos force-pushed the feat/gateway-track-redirect-counts branch 2 times, most recently from d311978 to b72e729 Compare February 6, 2022 10:42
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come a separate DO and not part of gateway metrics?

@vasco-santos
Copy link
Contributor Author

How come a separate DO and not part of gateway metrics?

I though about adding it to summary. But, the goal is to not have redirects with X-Forwarded-For header, plus other potential improvements with CF and Pinata.

So, decided to have them in separate to be easier to just remove later on, if we don't want it.

@vasco-santos vasco-santos force-pushed the feat/gateway-track-redirect-counts branch from b72e729 to afcbd01 Compare February 8, 2022 11:58
@vasco-santos vasco-santos requested a review from alanshaw February 8, 2022 12:08
@vasco-santos vasco-santos merged commit 88a9085 into main Feb 8, 2022
@vasco-santos vasco-santos deleted the feat/gateway-track-redirect-counts branch February 8, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants