fix: gateway get durable object request function #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
dcc29ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6aa203e.nft-storage-1at.pages.dev |
vasco-santos
force-pushed
the
fix/gateway-get-durable-request
branch
2 times, most recently
from
e8f920a to
f9735b5
Compare
vasco-santos
force-pushed
the
fix/gateway-get-durable-request
branch
3 times, most recently
from
ddae244 to
30a6a16
Compare
vasco-santos
force-pushed
the
fix/gateway-get-durable-request
branch
from
30a6a16 to
2e6d60b
Compare
alanshaw
reviewed
Feb 8, 2022
| if (controller.signal.aborted) { | ||
| return { | ||
| url: gwUrl, | ||
| aborted: true, |
There was a problem hiding this comment.
Can we please be specific that this is a timeout (timeout: true), or have aborted + reason - where reason is timeout.
We could maybe roll requestPreventedCode into this:
{
url: gwUrl,
aborted: true,
reason: REQUEST_PREVENTED_RATE_LIMIT_CODE
}And for timeout:
{
url: gwUrl,
aborted: true,
reason: 'TIMEOUT'
}...for all other successful you set aborted: false.
Just trying to get a standard return type out of this.
packages/gateway/src/gateway.js
Outdated
| @@ -288,6 +296,10 @@ async function updateGatewayMetrics( | |||
| gwResponse, | |||
| isWinner = false | |||
| ) { | |||
| if (!gwResponse.response?.status && !gwResponse.requestPreventedCode) { | |||
There was a problem hiding this comment.
Should this be checking aborted instead?
alanshaw
approved these changes
Feb 8, 2022
vasco-santos
force-pushed
the
fix/gateway-get-durable-request
branch
from
7bd69a5 to
dcc29ba
Compare
hugomrdias
added a commit
that referenced
this pull request
Feb 8, 2022
* 'main' of github.com:nftstorage/nft.storage: fix: gateway get durable object request function (#1264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two minor issues: