fix: increase gateway timeout #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
97f57ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://012b77e9.nft-storage-1at.pages.dev |
hugomrdias
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases gateway timeout to 60s (same as ipfs.io)
I was talking last night with @dchoi27 and we should increase the timeout as we might not have data in Peered Cluster nodes, and need to perform DHT lookups. This is particularly important for users that store their data in Pinning Services.
I was looking into
cf-ipfsandpinatadedicated gateway timeouts and they are bigger than 60s. But I think 60s should be a reasonable timeout to have.